You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2014/10/17 23:40:30 UTC
[Bug 57110] New: Fixed spelling+grammar, formatting, removed
commented out code etc.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57110
Bug ID: 57110
Summary: Fixed spelling+grammar, formatting, removed commented
out code etc.
Product: JMeter
Version: Nightly (Please specify date)
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: jmeter@ham1.co.uk
Created attachment 32122
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32122&action=edit
Initial code patch
While trying to fix Bug 54784 I've done a lot of reading/hunting and while I
was there I made some changes. Sorry for the large patch, hopefully this is ok,
I can split it up into smaller bits if that is easier?
Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57110] Fixed spelling+grammar, formatting, removed commented
out code etc.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57110
--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
I have committed quite a few of your changes in the commits listed below. If
you want to submit more patches, it would be nice, if the patches were split by
purpose, eg. "code reformatting", "javadoc correction", "logic simplification",
...
But thanks for your work nontheless.
Date: Sat Jan 31 10:59:42 2015
New Revision: 1656177
URL: http://svn.apache.org/r1656177
Log:
Bug: 57110
Reformat code, no functional change. Remove empty javadoc comments.
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java
jmeter/trunk/src/core/org/apache/jmeter/config/gui/RowDetailDialog.java
jmeter/trunk/src/core/org/apache/jmeter/control/gui/TestPlanGui.java
jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/AddToTree.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Load.java
jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSampler.java
jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java
Date: Sat Jan 31 11:02:21 2015
New Revision: 1656178
URL: http://svn.apache.org/r1656178
Log:
Bug: 57110
Assign variable only once.
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java
Date: Sat Jan 31 11:04:31 2015
New Revision: 1656179
URL: http://svn.apache.org/r1656179
Log:
Bug: 57110
Inline constant and get rid of then unneeded import.
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
Date: Sat Jan 31 11:05:48 2015
New Revision: 1656180
URL: http://svn.apache.org/r1656180
Log:
Bug: 57110
Convert to new for loop.
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java
Date: Sat Jan 31 11:06:56 2015
New Revision: 1656181
URL: http://svn.apache.org/r1656181
Log:
Bug: 57110
Correct typo
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSampler.java
Date: Sat Jan 31 11:09:00 2015
New Revision: 1656182
URL: http://svn.apache.org/r1656182
Log:
Bug: 57110
Lowercase variable name, since it is not a constant.
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSampler.java
Date: Sat Jan 31 11:10:01 2015
New Revision: 1656183
URL: http://svn.apache.org/r1656183
Log:
Bug: 57110
javadoc changes
Bugzilla Id: 57110
Modified:
jmeter/trunk/test/src/org/apache/jmeter/visualizers/GenerateTreeGui.java
Date: Sat Jan 31 11:10:57 2015
New Revision: 1656184
URL: http://svn.apache.org/r1656184
Log:
Bug: 57110
Simplify logic to make it even more efficient.
Bugzilla Id: 57110
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 57110] Fixed spelling+grammar, formatting, removed commented
out code etc.
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57110
--- Comment #1 from Graham Russell <jm...@ham1.co.uk> ---
Created attachment 32126
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32126&action=edit
More code tidy-up
Some more code tidy-up.
--
You are receiving this mail because:
You are the assignee for the bug.