[jira] [Comment Edited] (HBASE-11845) HFile tool should implement Tool, disable blockcache by default

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126506#comment-14126506 ] 

Enis Soztutar edited comment on HBASE-11845 at 9/9/14 2:59 AM:
---------------------------------------------------------------

+1. [~ndimiduk], let's get this in. 
Agreed with Andrew, maybe we should keep HFile main so that if any script is directly using HFile it will still work. However, HFile.main() should just call HFPP.main directly instead of what it does now so that Tool mechanics work. 


was (Author: enis):
+1. Nick, let's get this in. 
Agreed with Andrew, maybe we should keep HFile main so that if any script is directly using HFile it will still work. However, HFile.main() should just call HFPP.main directly instead of what it does now so that Tool mechanics work. 

> HFile tool should implement Tool, disable blockcache by default
> ---------------------------------------------------------------
>
>                 Key: HBASE-11845
>                 URL: https://issues.apache.org/jira/browse/HBASE-11845
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11845.00-0.98.patch, HBASE-11845.00.patch
>
>
> I tried using bin/hbase hfile in a memory-constrained environment. It crashed while trying to instantiate a blockcache. Went to override the configuration and found I couldn't.
> Refactor HFile to remove main(), put implementation entirely in HFilePrettyPrinter. Said class now extends Configured and implements Tool so configs can be overridden on cli. Also disabled blockcache by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)