You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 21:05:25 UTC
[GitHub] [arrow-datafusion] askoa opened a new pull request, #4446: Replace `&Option` with `Option<&T>`
askoa opened a new pull request, #4446:
URL: https://github.com/apache/arrow-datafusion/pull/4446
# Which issue does this PR close?
Part of #4424
Changed some occurrences of `&Option<T>` with `Option<&T>`
# Are there any user-facing changes?
There might be user facing changes as public functions are modified. Would leave it up to reviewers to add `api-change` tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4446: Replace `&Option` with `Option<&T>`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4446:
URL: https://github.com/apache/arrow-datafusion/pull/4446#issuecomment-1333628797
The CI check has been fixed in https://github.com/apache/arrow-datafusion/pull/4450
This PR looks like it has some conflicts with master that now need to be fixed, so the next run should pass.
Thanks again @askoa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4446: Replace `&Option` with `Option<&T>`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4446:
URL: https://github.com/apache/arrow-datafusion/pull/4446#issuecomment-1333855961
Benchmark runs are scheduled for baseline = 38e9f30c182d278edb71bc2560996e7f5cbd9d8f and contender = bde3c91f820a51034de27b0597caeea3ef0cdd9e. bde3c91f820a51034de27b0597caeea3ef0cdd9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b948192c2f8d429db45bef7d3aa9452b...9371a6950886465ab471365793e54161/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/38152ba218ee4d8f8502d6961fb1ee0a...60e0ecb945eb40678b4a0685af09ed3d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/485aa09104c04bf3a711ee275d5cdc61...409197048a644f6d884e08d8654664de/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/da2a5edb664543dbaf9b60bb9e16ede0...86b7987873154f998033135315d9b827/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] askoa commented on pull request #4446: Replace `&Option` with `Option<&T>`
Posted by GitBox <gi...@apache.org>.
askoa commented on PR #4446:
URL: https://github.com/apache/arrow-datafusion/pull/4446#issuecomment-1332823991
The build failure seems unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4446: Replace `&Option` with `Option<&T>`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4446:
URL: https://github.com/apache/arrow-datafusion/pull/4446#issuecomment-1333853334
Thanks @askoa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4446: Replace `&Option` with `Option<&T>`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4446:
URL: https://github.com/apache/arrow-datafusion/pull/4446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org