You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Jinchul Kim (JIRA)" <ji...@apache.org> on 2017/12/16 13:11:00 UTC
[jira] [Created] (IMPALA-6335) Remove the unnecessary decorator
"pytest.mark.execute_serially" from tests which can be run parallely
Jinchul Kim created IMPALA-6335:
-----------------------------------
Summary: Remove the unnecessary decorator "pytest.mark.execute_serially" from tests which can be run parallely
Key: IMPALA-6335
URL: https://issues.apache.org/jira/browse/IMPALA-6335
Project: IMPALA
Issue Type: Improvement
Components: Infrastructure
Affects Versions: Impala 2.10.0
Reporter: Jinchul Kim
Priority: Minor
Regarding the decorator "pytest.mark.execute_serially", I saw all the test cases are marked as execute_serially in tests/shell/test_shell_interactive.py. I guess a few tests should be run exclusively, but the other tests do not require the serial option. What do you think about this? I think we should consider to use the decorator when adding test cases. Minimized serial run can help to reduce overall test running time by parallelism.
I think the following cases do not require the decorator.
a. Check consistency from test result
b. Test query cancellation
c. Test shell options which are effective on local shell
- From Tim's comment:
I think you're right that many of the shell tests don't inherently
require to be executed serially. Some of them would require work to execute
in parallel, particularly the ones that inspect files like .impalahistory
and tests that check the values of global impala daemon metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)