[GitHub] [incubator-echarts] newraina commented on a change in pull request #12001: fix(dataZoom): avoid freezing when range 'start' equals 'end' #11175

[GitBox <gi...@apache.org>]

newraina commented on a change in pull request #12001: fix(dataZoom): avoid freezing when range 'start' equals 'end' #11175
URL: https://github.com/apache/incubator-echarts/pull/12001#discussion_r368848072
 
 

 ##########
 File path: src/component/dataZoom/InsideZoomView.js
 ##########
 @@ -114,11 +114,15 @@ var roamHandlers = {
         var directionInfo = getDirectionInfo[coordSysName](
             null, [e.originX, e.originY], axisModel, controller, coordInfo
         );
+
+        // diff=0 will freezing dataZoom
+        var rangeDiff = (range[1] - range[0]) || 0.1;
 
 Review comment:
   provide an option named `dataZoom.minRangeDiff` and its default value is `0.1`, right?
   
   `range` is an internal concept, I don't know if `rangeDiff` is a good name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org