You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/09 10:23:15 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29439: Add time to leave for finished jobs in Kubernetes
potiuk opened a new pull request, #29439:
URL: https://github.com/apache/airflow/pull/29439
When you upgrade/change job in K8S that has been finished and not manually removed, this leads to "Field is immutable" error.
This is a known kubernetes issue:
https://github.com/kubernetes/kubernetes/issues/89657
And there are some workarounds (manually removing the job for example), but the only good solution is possible only in K8S 1.23+ with ttlSecondsAfterFinished set for the job, so that K8S can auto
clean it.
This PR adds it conditionally for K8S >= 1.23
Fixes: #29438
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29439: Add time to live for finished jobs in Kubernetes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29439:
URL: https://github.com/apache/airflow/pull/29439#issuecomment-1427532718
Closing in favour of https://github.com/apache/airflow/pull/29314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #29439: Add time to live for finished jobs in Kubernetes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #29439: Add time to live for finished jobs in Kubernetes
URL: https://github.com/apache/airflow/pull/29439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29439: Add time to live for finished jobs in Kubernetes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29439:
URL: https://github.com/apache/airflow/pull/29439#issuecomment-1427241358
> It's an interesting change, but there's still a chance of getting the same error if for some reason we run the jobs twice before the TTL ends, on top of that we can add `{{ .Release.Revision }}` as suffix for job name -> `metadata.name: {{ .Release.Name }}-<job name>-{{ .Release.Revision }}`, and keep the cleanup task for garbage collection.
Thought about it, but I am not sure if there is another reason why we wanted to keep the job names "static" - @jedcunningham @dstandish ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29439: Add time to live for finished jobs in Kubernetes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29439:
URL: https://github.com/apache/airflow/pull/29439#issuecomment-1427090425
Hey @dstandish @jedcunningham -> WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org