[GitHub] [superset] villebro commented on a diff in pull request #19714: fix: create virtual table with exotic type

[GitBox <gi...@apache.org>]

villebro commented on code in PR #19714:
URL: https://github.com/apache/superset/pull/19714#discussion_r850227869


##########
superset/connectors/sqla/utils.py:
##########
@@ -86,7 +83,7 @@ def get_physical_table_metadata(
             col.update(
                 {
                     "type": "UNKNOWN",
-                    "generic_type": None,
+                    "type_generic": None,

Review Comment:
   this was a bycatch (see line 79/76 above with the correct key) when I worked on adding proper `TypedDict`s for these objects (opening up separate PR for that one, but I thought it worthwhile to fix this error right away).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org