You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/08 13:52:49 UTC
[GitHub] [airflow] feluelle opened a new pull request #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
feluelle opened a new pull request #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215
When building production docker image via breeze `./breeze build-image --production-image --install-airflow-version=1.10.10rc4` and entering it via `./breeze --production-image`, the `airflow version` is `2.0.0.dev0` which should be `1.10.10rc4` as specified via `--install-airflow-version`.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611458766
The --install-airflow-version is not persistent so if you rebuild the image next time it will use default sources. So every time you rebuild the image with 1.10.10rc4 you need to specify the flag. This is consistent with how the CI image works as well (you need to specify the flag to install another airflow version in the container).
I created #8229 to fix the display issue - it always takes the AIRFLOW_VERSION from the production image so we can be sure the airflow version is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611461104
The `export` here re-init the variable doesn't it? So the `declare -a` does no longer count hence the variable is missing when `verbose_docker build`. You can see it when you change `set -u` to `set +u` right before it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611642002
Hey @feluelle - I just made PR fixing this even better #8234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611455698
Then it must be a docker caching issue? Because I already had a image like that but with airflow version 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-610976439
For example with these changes. I still get `Airflow source version: 2.0.0.dev0` but the installed version is correct (`1.10.10rc4`). Of course when I add `--install-airflow-version=1.10.10rc4` it works. :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611455698
Then it must be a docker caching issue? Because I already had a image like that but with airflow version 2.0.
So then I wanted to test the current release candidate and build with `--install-airflow-version=1.10.10rc4` and after that I still had version 2.0 in the container but the image was successfully built 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611469061
@potiuk can you reproduce these steps on your side pls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle closed pull request #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle closed pull request #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611461104
The `export` here re-init the variable doesn't it? ~~So the `declare -a` does no longer count hence~~ the variable is missing when `verbose_docker build`. You can see it when you change `set +u` to `set -u` right before it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611469061
@potiuk can you run these steps on your side pls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611498426
@feluelle - are you building on Mac ? I think that might be the issue. Will check it on Mac soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-610976145
I will take a look at this evening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-610976439
For example with these changes I still get `Airflow source version: 2.0.0.dev0` but the installed version is correct (`1.10.10rc4`). Of course when I add `--install-airflow-version=1.10.10rc4` it works. :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611459814
> So every time you rebuild the image with 1.10.10rc4 you need to specify the flag.
I did.
The first time I did not specify it because I wanted `2.0.0.dev0` (the latest master).
And now I wanted to install the rc so I added the flag but the container that was built then still had version 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611455698
Then it must be a (docker?) caching issue? Because I already had a image like that but with airflow version 2.0.
So then I wanted to test the current release candidate and build with `--install-airflow-version=1.10.10rc4` and after that I still had version 2.0 in the container but the image was successfully built 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-610975228
@potiuk I am still seeing the issue that `Airflow source version` which will be displayed during startup of breeze is not in sync with the actual installed `airflow version`. Do you know how this can be fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611468591
_With breeze code from latest master_
1. `./breeze build-image --production-image`
```
Successfully built b800f3edf319
Successfully tagged apache/airflow:master-python3.7
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.7
Airflow source version: 2.0.0.dev0
Python version: 3.7
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
```
2. `./breeze --production-image`
```
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.7
Airflow source version: 2.0.0.dev0
Python version: 3.7
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
```
3. `airflow version`
```
2.0.0.dev0
```
4. `./breeze build-image --production-image --install-airflow-version=1.10.10rc4`
```
Successfully built d9a8ea5a24b4
Successfully tagged apache/airflow:master-python3.7
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.7
Airflow source version: 1.10.10rc4
Python version: 3.7
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
Airflow installed from: 1.10.10rc4
```
5. `./breeze --production-image`
```
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.7
Airflow source version: 2.0.0.dev0
Python version: 3.7
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
```
6. `airflow version`
```
2.0.0.dev0
```
I see the following during point 4.:
```
---> Running in ef19eaafa0e2
+ pip install --user '.[async,aws,azure,celery,dask,elasticsearch,gcp,kubernetes,mysql,postgres,redis,slack,ssh,statsd,virtualenv]' --constraint /requirements.txt
```
The version is missing there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611461250
Was the image actually built the second time you run it? If none of the sensitive files are touched, the image is not rebuilt at all. In order to force building it you need to specify --force-build or use 'build-image' command. So if you built it first without --install-airflow-version flag and then you tried to enter it (but not build) with the flag - then it might explain what happened.
Maybe in this case I should match the version required, with the actual version of image you have and if they are different I should force-build the image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611453215
@feluelle I understand it's only about the version displayed when you enter it `Airflow source version: 2.0.0.dev` The version inside is correct?
I run it with the current master and I have this:
```
./breeze build-image --production-image --install-airflow-version=1.10.10rc4
....
Successfully built 221d3826678d
Successfully tagged apache/airflow:master-python3.6
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.6
Airflow source version: 1.10.10rc4
Python version: 3.6
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
Airflow installed from: 1.10.10rc4
```
Then I tried the image manually:
```
[jarek:~/code/airflow] master+ 9m14s 127 ± docker run -it apache/airflow:master-python3.6 version
1.10.10rc4
```
And via breeze:
```
./breeze --production-image
...
Creating network "docker-compose_default" with the default driver
Creating docker-compose_postgres_1 ... done
DB_BACKEND=postgresql+psycopg2
DB_HOST=postgres
DB_PORT=5432
..
airflow@c09b28bc0260:/opt/airflow$ airflow version
1.10.10rc4
```
However indeed the airflow version displayed next to the asciiart is wrong (I will fix it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611500745
Yes, Mojave (10.14.6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611461104
The `export` here re-init the variable doesn't it? So the `declare -a` does no longer count hence the variable is missing when `verbose_docker build`. You can see it when you change `set +u` to `set -u` right before it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-612369362
Thanks @potiuk - can confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611468591
_With breeze code from latest master_
1. `./breeze build-image --production-image`
```
Successfully built b800f3edf319
Successfully tagged apache/airflow:master-python3.7
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.7
Airflow source version: 2.0.0.dev0
Python version: 3.7
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
```
2. `./breeze --production-image`
```
Use production image.
Branch name: master
Docker image: apache/airflow:master-python3.7
Airflow source version: 2.0.0.dev0
Python version: 3.7
DockerHub user: apache
DockerHub repo: airflow
Backend: postgres 9.6
```
3. `airflow version`
```
2.0.0.dev0
```
4. `./breeze build-image --production-image --install-airflow-version=1.10.10rc4`
... (WIP)
I already see:
```
---> Running in ef19eaafa0e2
+ pip install --user '.[async,aws,azure,celery,dask,elasticsearch,gcp,kubernetes,mysql,postgres,redis,slack,ssh,statsd,virtualenv]' --constraint /requirements.txt
```
The version is missing there.. so it will again install latest master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle edited a comment on issue #8215: Fix breeze
building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
feluelle edited a comment on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-611459814
> So every time you rebuild the image with 1.10.10rc4 you need to specify the flag.
I did.
The first time I did not specify it because I wanted `2.0.0.dev0` (the latest master).
And now I wanted to install the rc so I added the flag but the container that was created from the new image with `--install-airflow-version=1.10.10rc4` then still had version 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8215: Fix breeze building
production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8215: Fix breeze building production image not recognizing EXTRA_DOCKER_PROD_BUILD_FLAGS
URL: https://github.com/apache/airflow/pull/8215#issuecomment-610974286
Thanks @feluelle !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services