[jira] [Created] (LUCENE-6770) FSDirectory ctor should use getAbsolutePath instead of getRealPath for directory

["Vladimir Kuzmin (JIRA)" <ji...@apache.org>]

Vladimir Kuzmin created LUCENE-6770:
---------------------------------------

             Summary: FSDirectory ctor should use getAbsolutePath instead of getRealPath for directory
                 Key: LUCENE-6770
                 URL: https://issues.apache.org/jira/browse/LUCENE-6770
             Project: Lucene - Core
          Issue Type: Improvement
          Components: core/store
    Affects Versions: 5.2.1
         Environment: OS X, Linux
            Reporter: Vladimir Kuzmin


After upgrade from 4.1 to 5.2.1 I found that one of our test failed. Appeared the guilty was FSDirectory that converts given Path to Path.getRealPath. As result the test will fail:


Path p = Paths.get("/var/lucene_store");
FSDirectory d = new FSDirectory(p);
assertEqual(p.toString(), d.getDirectory().toString());

It because /var/lucene_store is a symlink and 
Path directory =path.getRealPath(); 
resolves it to /private/var/lucene_store

I think this is bad design decision because "direcrory" isn't just internal state but is exposed in a public interface and "getDirectory()" is widely used to initialize other components. 

It should use paths.getAbsolutePath() instead.

build and "ant test" were successful after fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org