You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by anabranch <gi...@git.apache.org> on 2016/06/27 04:07:44 UTC

[GitHub] spark pull request #13916: [SPARK-16220] Revert Change to Bring Back SHOW FU...

GitHub user anabranch opened a pull request:

    https://github.com/apache/spark/pull/13916

    [SPARK-16220] Revert Change to Bring Back SHOW FUNCTIONS Functionality

    ## What changes were proposed in this pull request?
    
    - Fix tests regarding show functions functionality
    - Revert `catalog.ListFunctions` and `SHOW FUNCTIONS` to return to `Spark 1.X` functionality.
    - 
    
    ## How was this patch tested?
    
    Unit Tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anabranch/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13916
    
----
commit 17b3c580518663577b015d30d6700e32e3aa2052
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-05-11T01:44:28Z

    fix SPARK-15264, add test cases

commit 85d08434b620241d698edeaa6557e8a715816185
Author: Bill Chambers <wc...@ischool.berkeley.edu>
Date:   2016-05-11T02:48:22Z

    Rename test case

commit 0ed0b4c93b3be6e77ee8731f9c511b619c810625
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-05-11T20:35:36Z

    Fix according to @andrewor14 comments, rename C0 to _c0, fix null checks

commit e380f3236cf72aea08af815c600c0169ab358852
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-05-11T20:37:44Z

    Merge branch 'master' of github.com:anabranch/spark

commit d665bea023b5f4aa9bfe2b2ccbc46586e07bc396
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-05-11T20:41:45Z

    fix tests

commit d98371859d78706cb9673f253b4dccbffb9fc385
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-05-11T22:09:49Z

    fix python test failure

commit 3be1936fe4a0ab86a4358d02b3879ea3db87c889
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-09T21:02:19Z

    Merge branch 'master' of https://github.com/apache/spark

commit 3d6e8e234f69a5f78caa36153c64a00ae18404ba
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-24T16:43:28Z

    Merge branch 'master' of https://github.com/apache/spark

commit b57b3171420666942425da567674a478960a944d
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-27T03:46:11Z

    Merge branch 'master' of https://github.com/apache/spark

commit 42212def9c832208fddf9f3ea61673a60816b320
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-27T03:50:35Z

    added pyspark tests for list functions

commit 93484b2ad53731875f47927b720f285d0237453d
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-27T03:51:46Z

    revert functionality for list functions

commit a980cb2acd8fbfa52edf45b7cd28a6d6bc72a742
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-27T03:54:34Z

    Revert Scala test

commit db01c61bfd3d039a5dfe4f23b49f0025835c1587
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-27T03:57:20Z

    fix more scala tests

commit 7c239a5c7dfac5288733cff1664cc929bc780b9e
Author: Bill Chambers <bi...@databricks.com>
Date:   2016-06-27T04:00:11Z

    fixed hive functions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220] Revert Change to Bring Back SHOW FUNCTIONS...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    **[Test build #61283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61283/consoleFull)** for PR 13916 at commit [`7c239a5`](https://github.com/apache/spark/commit/7c239a5c7dfac5288733cff1664cc929bc780b9e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61283/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220] Revert Change to Bring Back SHOW FUNCTIONS...

Posted by anabranch <gi...@git.apache.org>.
Github user anabranch commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    jenkins test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    LGTM - merging to master/2.0. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    **[Test build #61283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61283/consoleFull)** for PR 13916 at commit [`7c239a5`](https://github.com/apache/spark/commit/7c239a5c7dfac5288733cff1664cc929bc780b9e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    **[Test build #61292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61292/consoleFull)** for PR 13916 at commit [`c8a0389`](https://github.com/apache/spark/commit/c8a03894f24693d141b64310d22c64fb5aea9d22).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61292/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    **[Test build #61292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61292/consoleFull)** for PR 13916 at commit [`c8a0389`](https://github.com/apache/spark/commit/c8a03894f24693d141b64310d22c64fb5aea9d22).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13916: [SPARK-16220][SQL] Revert Change to Bring Back SHOW FUNC...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13916
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #13916: [SPARK-16220][SQL] Revert Change to Bring Back SH...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/13916


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org