You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/21 13:54:26 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4417: Modify alter view to drop/create view
Pearl1594 opened a new pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417
## Description
As a best practice, it is better to drop and create a new view as opposed to altering a view. The PR addresses changing alter view to re-creation of the views after being dropped
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Ran upgrade test:
1. deployed a 4.14 setup
2. Created some projects, added/invites a few users
3. Upgraded to 4.15
4. listed projects, project invitations to verify that they are still intact
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-717346182
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-717479414
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-714463978
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-714487827
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-717478743
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-717703266
<b>Trillian test result (tid-3088)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33571 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4417-t3088-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-713616128
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-714463717
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-717305314
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-717304691
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-714487036
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-714483284
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4417: Modify alter view to drop/create view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4417:
URL: https://github.com/apache/cloudstack/pull/4417#issuecomment-713617099
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org