[GitHub] [knox] lmccay opened a new pull request #515: V1.6.0

[GitBox <gi...@apache.org>]

lmccay opened a new pull request #515:
URL: https://github.com/apache/knox/pull/515


   ## What changes were proposed in this pull request?
   
   Invalidate any originalUrl being used in the flow for KnoxSSO that contains user information (username and password).
   There is no reason for an SSO flow to result in username and password being sent by the browser as part of the URL and would represent poor credential hygiene.
   
   This change explicitly checks the incoming originalUrl for the existence of userInfo and if the url contains it the flow is disrupted as possible phishing attack.
   
   ## How was this patch tested?
   
   Existing unit tests and new unit tests added for Urls.containsUserInfo method.
   Manually tested a url with userinfo and observed expected behavior.
   Manually tested a valid url and observed normal KnoxSSO flow success.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [knox] lmccay merged pull request #515: V1.6.0

[GitBox <gi...@apache.org>]

lmccay merged pull request #515:
URL: https://github.com/apache/knox/pull/515


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org