[GitHub] spark issue #16516: [SPARK-19155][ML] MLlib GeneralizedLinearRegression fami...

[imatiach-msft <gi...@git.apache.org>]

Github user imatiach-msft commented on the issue:

    https://github.com/apache/spark/pull/16516
  
    Hmm ok, I guess that's fine.  I'm just worried this line is duplicated, maybe you could add a method for it and put it in a common place:
    (value: String) => supportedFamilyNames.contains(value.toLowerCase)) 
    
    Otherwise the code looks great to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org