You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/02/08 07:23:37 UTC
zeppelin git commit: When gear icon is clicked,
scroll the page to the top to show the interpreter bindings
Repository: zeppelin
Updated Branches:
refs/heads/master d9a201388 -> 5900f0d5f
When gear icon is clicked, scroll the page to the top to show the interpreter bindings
### What is this PR for?
When someone is browsing a notebook and they click the *gear* button of interpreter bindings, the bindings do come up, but the person might not realize since it opens on the top of the page, and they don't get any feedback that the bindings have opened. We should scroll up the page to show the bindings. This will also act as the feedback of clicking the *gear* button.
### What type of PR is it?
[Improvement]
### Todos
* None
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2047
### How should this be tested?
Create few (say 10) paragraphs and scroll down to the last paragraph. Now click the *gear* icon meant to open the interpreter bindings. The view should have scrolled up to show the bindings.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No. Its a usability improvement.
Author: Beria <be...@qubole.com>
Closes #1971 from beriaanirudh/master and squashes the following commits:
e7b8e51 [Beria] scroll gracefully
a0f521a [Beria] When gear icon is clicked, scroll the page to the top to show the intepreter bindings
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/5900f0d5
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/5900f0d5
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/5900f0d5
Branch: refs/heads/master
Commit: 5900f0d5f0ab616eb2c7de110a91a8df05bc880a
Parents: d9a2013
Author: Beria <be...@qubole.com>
Authored: Sat Feb 4 18:47:54 2017 +0530
Committer: Lee moon soo <mo...@apache.org>
Committed: Wed Feb 8 16:23:11 2017 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/notebook/notebook.controller.js | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/5900f0d5/zeppelin-web/src/app/notebook/notebook.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js
index b434b64..11c2c58 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.js
@@ -614,6 +614,7 @@ function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope,
} else {
$scope.openSetting();
$scope.closePermissions();
+ angular.element('html, body').animate({ scrollTop: 0 }, 'slow');
}
};