[GitHub] [skywalking] wu-sheng commented on issue #7414: Information on Openapi based Endpoint Grouping

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #7414:
URL: https://github.com/apache/skywalking/issues/7414#issuecomment-893447834


   > What do you want to know?
   1 - Are there any limits on openapi yaml files? I have used EndpointGroupingRuleReader4OpenapiTest and that class does not load my openapi definition which is over 3000 lines. I figured checkstyle is limiting the definition file limits. Can i increase these values via ENV variable?
   
   I think we don't limit size, and checkstyle is only working for IDE, rather than runtime. Could you share more about this?
   
   > 2 - I couldn't tell if skywalking-server correctly loaded my openapi file or not based on logs. I think there should be logging if no file loaded etc.
   
   Welcome to send a pull request to enhance this. This is a new feature, we are glad to see the feedback.
   
   > 3 - getGroupRegex method does not care for statically added server context paths. (For example endpoint is /records but server is setup as /api/records). This information usually goes to servers.url in openapi definition (server.url being '/api' in this case). Should we consider such setup?
   
   We should consider that. Do you have anything to pull request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org