You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/12/16 17:21:40 UTC

[GitHub] [accumulo] billierinaldi commented on issue #1450: Fix #1373 Support the init scope in some VolumeChoosers

billierinaldi commented on issue #1450: Fix #1373 Support the init scope in some VolumeChoosers
URL: https://github.com/apache/accumulo/pull/1450#issuecomment-566157877
 
 
   @ctubbsii After fixing the first error in VolumeChooserIT (which was that ClientContext was always reading the instance ID from ZooKeeper), we saw another error from PerTableVolumeChooser that was due to no volume chooser being configured for the init or default scope. Previously, the user could just configure a volume chooser for the logger scope, since that was the only scope where we were constructing a volume chooser. Since introducing volume choosers for the init scope would require the user to change their config, Karthick's latest patch falls back to a random chooser when the neither the desired nor the default scope are specified. This preserves the old behavior for the init scope, but changes the behavior for the logger scope (which previously threw an error instead of falling back to random).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services