You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwhisk.apache.org by ra...@apache.org on 2019/05/15 18:22:55 UTC

[incubator-openwhisk-runtime-nodejs] branch master updated: Remove deadcode. (#129)

This is an automated email from the ASF dual-hosted git repository.

rabbah pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk-runtime-nodejs.git


The following commit(s) were added to refs/heads/master by this push:
     new 14d2af8  Remove deadcode. (#129)
14d2af8 is described below

commit 14d2af8e50eda5d20b0f147fe297c19f054e9cc6
Author: rodric rabbah <ro...@gmail.com>
AuthorDate: Wed May 15 14:22:50 2019 -0400

    Remove deadcode. (#129)
---
 core/nodejsActionBase/runner.js | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/core/nodejsActionBase/runner.js b/core/nodejsActionBase/runner.js
index 7f37e3b..ff6fcf3 100644
--- a/core/nodejsActionBase/runner.js
+++ b/core/nodejsActionBase/runner.js
@@ -33,15 +33,6 @@ function NodeActionRunner() {
 
     this.userScriptMain = undefined;
 
-    // This structure is reset for every action invocation. It contains two fields:
-    //   - completed; indicating whether the action has already signaled completion
-    //   - next; a callback to be invoked with the result of the action.
-    // Note that { error: ... } results are still results.
-    var callback = {
-        completed : undefined,
-        next      : function (result) { return; }
-    };
-
     this.init = function(message) {
         function assertMainIsFunction() {
             if (typeof thisRunner.userScriptMain !== 'function') {
@@ -91,9 +82,6 @@ function NodeActionRunner() {
     this.run = function(args) {
         return new Promise(
             function (resolve, reject) {
-                callback.completed = undefined;
-                callback.next = resolve;
-
                 try {
                     var result = thisRunner.userScriptMain(args);
                 } catch (e) {