You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2009/05/01 06:28:30 UTC
[jira] Commented: (ZOOKEEPER-376) ant test target re-compiles
cppunit code every time
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704891#action_12704891 ]
Hadoop QA commented on ZOOKEEPER-376:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406976/ZOOKEEPER-376.patch
against trunk revision 769885.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/57/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/57/console
This message is automatically generated.
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.