You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "jorgebay (GitHub)" <gi...@apache.org> on 2019/02/27 14:57:27 UTC

[GitHub] [tinkerpop] jorgebay opened pull request #1073: TINKERPOP-2166 Cache expression to obtain the method in PSerializer

https://issues.apache.org/jira/browse/TINKERPOP-2166

Implement a cache for the search of the method in P deserialization.

Includes a micro benchmark:

Before:

```
Benchmark                                 Mode  Cnt      Score      Error  Units
GraphBinaryReaderWriterBenchmark.readP1  thrpt   20  74574.850 ± 2466.040  ops/s
```

With this patch:

```
Benchmark                                 Mode  Cnt        Score       Error  Units
GraphBinaryReaderWriterBenchmark.readP1  thrpt   20  1483588.719 ± 77339.678  ops/s
```

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1073 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1073: TINKERPOP-2166 Cache expression to obtain the method in PSerializer

Posted by "spmallette (GitHub)" <gi...@apache.org>.
As soon as this merges, I will backport some of this logic to `tp33` and apply it to GraphSON (TINKERPOP-2168). 

Needs CHANGELOG entry but other than that VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1073 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] nastra commented on issue #1073: TINKERPOP-2166 Cache expression to obtain the method in PSerializer

Posted by "nastra (GitHub)" <gi...@apache.org>.
+1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1073 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay closed pull request #1073: TINKERPOP-2166 Cache expression to obtain the method in PSerializer

Posted by "jorgebay (GitHub)" <gi...@apache.org>.
[ pull request closed by jorgebay ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1073 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org