You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/25 14:58:24 UTC

[GitHub] [cassandra] bereng opened a new pull request #652: Cassandra 15901

bereng opened a new pull request #652:
URL: https://github.com/apache/cassandra/pull/652


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on a change in pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #652:
URL: https://github.com/apache/cassandra/pull/652#discussion_r450054263



##########
File path: src/java/org/apache/cassandra/utils/FBUtilities.java
##########
@@ -130,16 +130,24 @@ public static MessageDigest newMessageDigest(String algorithm)
     public static InetAddress getJustLocalAddress()
     {
         if (localInetAddress == null)
-            try
-            {
-                localInetAddress = DatabaseDescriptor.getListenAddress() == null
-                                    ? InetAddress.getLocalHost()
-                                    : DatabaseDescriptor.getListenAddress();
-            }
-            catch (UnknownHostException e)
+        {
+            if (DatabaseDescriptor.getListenAddress() == null)
             {
-                throw new RuntimeException(e);
+                try
+                {
+                    localInetAddress = InetAddress.getLocalHost();

Review comment:
       @snazy I would reword
   
   > InetAddress.getLocalHost() was used to resolve listen_address to {}, this can cause issues. Please check your node's config and set the listen_address in cassandra.yaml
   
   to
   
   > InetAddress.getLocalHost() was used to resolve listen_address to {}, double check this is correct. Please check your node's config and set the listen_address in cassandra.yaml accordingly if applicable.
   
   Why? getLocalHost may be the right thing and `can cause issues` sounds like almost a certainty it will cause them. I'd favor a milder wording. Also listen_address you only set up unless you set a device to listen on iirc they are exclusive, so you set listen_address only if applicable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #652:
URL: https://github.com/apache/cassandra/pull/652#issuecomment-651684293


   - [CI j11](https://app.circleci.com/pipelines/github/bereng/cassandra/52/workflows/573ad5be-e34d-4668-a0af-2726d4b35568) Failure seems unrelated
   - [CI j8](https://app.circleci.com/pipelines/github/bereng/cassandra/52/workflows/16e15155-7dce-4877-86f5-315c6a837d36) Seems to be a new flaky tests but unrelated to the PR imo


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng edited a comment on pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng edited a comment on pull request #652:
URL: https://github.com/apache/cassandra/pull/652#issuecomment-654155772


   CI runs:
   
   [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/44042930-ea9f-4b02-88d6-91b36d1d9bd6):
   - j8unit ActiveRepairServiceTest: Passes locally, ConnectionTest: [Known](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/) offender
   - j8_dtests-no-vnodes TestTransientReplicationRing looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest-novnode.transient_replication_ring_test/TestTransientReplicationRing/test_remove/history/) and passes locally
   - j8_dtests-with-vnodes TestIncRepair [known](https://issues.apache.org/jira/browse/CASSANDRA-15894) offender
   - j11unit ValidationExecutorTest passes locally
   - j11 dtests-with-vnodes test_manual_session_force_cancel passes locally, [test_restart_node_localhost](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest.pushed_notifications_test/TestPushedNotifications/test_restart_node_localhost/) known offender
   
   [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a)
   - j11unit testNoTreesRetainedAfterDifference passes locally
   - j11jvm_dtest Weird VM [failure](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a/jobs/544) and passes locally
   - dtests-no-vnodes: test_repaired_tracking_with_partition_deletes passes locally
   
   Ci-cass juni one [weird](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/165/) VM failure, unrelated?
   
   Waiting on [ci-cass](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/196/) to complete the full run. Will update with results later:
   - [ChecksummingTransformerTest](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cdc/126/testReport/junit/org.apache.cassandra.transport.frame.checksum/ChecksummingTransformerTest/corruptionCausesFailure_cdc/) I have seen this fail locally and looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.transport.frame.checksum/ChecksummingTransformerTest/history/)
   - [LongSharedExecutorPoolTest.testPromptnessOfExecution](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-burn/131/testReport/junit/org.apache.cassandra.concurrent/LongSharedExecutorPoolTest/testPromptnessOfExecution/) passes locally
   - [testMessagePurging-compression](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-compression/128/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessagePurging_compression/) known [offender](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/history/) also locally
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on a change in pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #652:
URL: https://github.com/apache/cassandra/pull/652#discussion_r450054263



##########
File path: src/java/org/apache/cassandra/utils/FBUtilities.java
##########
@@ -130,16 +130,24 @@ public static MessageDigest newMessageDigest(String algorithm)
     public static InetAddress getJustLocalAddress()
     {
         if (localInetAddress == null)
-            try
-            {
-                localInetAddress = DatabaseDescriptor.getListenAddress() == null
-                                    ? InetAddress.getLocalHost()
-                                    : DatabaseDescriptor.getListenAddress();
-            }
-            catch (UnknownHostException e)
+        {
+            if (DatabaseDescriptor.getListenAddress() == null)
             {
-                throw new RuntimeException(e);
+                try
+                {
+                    localInetAddress = InetAddress.getLocalHost();

Review comment:
       @snazy I would reword
   
   > InetAddress.getLocalHost() was used to resolve listen_address to {}, this can cause issues. Please check your node's config and set the listen_address in cassandra.yaml
   
   to
   
   > InetAddress.getLocalHost() was used to resolve listen_address to {}, double check this is correct. Please check your node's config and set the listen_address in cassandra.yaml accordingly if applicable.
   
   Why? getLocalHost may be the right thing and `can cause issues` sounds like almost a certainty it will cause them. I'd favor a milder wording. Also listen_address you only set up unless you set a device to listen on iirc they are exclusive, so you set listen_address only if applicable. Wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng edited a comment on pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng edited a comment on pull request #652:
URL: https://github.com/apache/cassandra/pull/652#issuecomment-654155772


   CI runs:
   
   [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/44042930-ea9f-4b02-88d6-91b36d1d9bd6):
   - j8unit ActiveRepairServiceTest: Passes locally, ConnectionTest: [Known](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/) offender
   - j8_dtests-no-vnodes TestTransientReplicationRing looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest-novnode.transient_replication_ring_test/TestTransientReplicationRing/test_remove/history/) and passes locally
   - j8_dtests-with-vnodes TestIncRepair [known](https://issues.apache.org/jira/browse/CASSANDRA-15894) offender
   - j11unit ValidationExecutorTest passes locally
   - j11 dtests-with-vnodes test_manual_session_force_cancel passes locally, [test_restart_node_localhost](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest.pushed_notifications_test/TestPushedNotifications/test_restart_node_localhost/) known offender
   
   [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a)
   - j11unit testNoTreesRetainedAfterDifference passes locally
   - j11jvm_dtest Weird VM [failure](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a/jobs/544) and passes locally
   - dtests-no-vnodes: test_repaired_tracking_with_partition_deletes passes locally
   
   Ci-cass juni one [weird](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/165/) VM failure, unrelated?
   
   [ci-cass](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/196/) full run. Note: jenkins final report is broken, it collects results from other runs, check stages individually making sure commit ids match.
   - [ChecksummingTransformerTest](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cdc/126/testReport/junit/org.apache.cassandra.transport.frame.checksum/ChecksummingTransformerTest/corruptionCausesFailure_cdc/) I have seen this fail locally and looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.transport.frame.checksum/ChecksummingTransformerTest/history/)
   - [LongSharedExecutorPoolTest.testPromptnessOfExecution](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-burn/131/testReport/junit/org.apache.cassandra.concurrent/LongSharedExecutorPoolTest/testPromptnessOfExecution/) passes locally
   - [testMessagePurging-compression](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-compression/128/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessagePurging_compression/) known [offender](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/history/) also locally
   - TestPushedNotifications.test_restart_node_localhost is a known failure [CASSANDRA-15912](https://issues.apache.org/jira/browse/CASSANDRA-15912)
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] snazy commented on a change in pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
snazy commented on a change in pull request #652:
URL: https://github.com/apache/cassandra/pull/652#discussion_r450100126



##########
File path: src/java/org/apache/cassandra/utils/FBUtilities.java
##########
@@ -130,16 +130,24 @@ public static MessageDigest newMessageDigest(String algorithm)
     public static InetAddress getJustLocalAddress()
     {
         if (localInetAddress == null)
-            try
-            {
-                localInetAddress = DatabaseDescriptor.getListenAddress() == null
-                                    ? InetAddress.getLocalHost()
-                                    : DatabaseDescriptor.getListenAddress();
-            }
-            catch (UnknownHostException e)
+        {
+            if (DatabaseDescriptor.getListenAddress() == null)
             {
-                throw new RuntimeException(e);
+                try
+                {
+                    localInetAddress = InetAddress.getLocalHost();

Review comment:
       Yea, not opposed to a milder wording as long as it becomes clear that people should always configure it and not rely on (dangerous) defaults.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng edited a comment on pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng edited a comment on pull request #652:
URL: https://github.com/apache/cassandra/pull/652#issuecomment-651684293


   - [CI j11](https://app.circleci.com/pipelines/github/bereng/cassandra/52/workflows/573ad5be-e34d-4668-a0af-2726d4b35568) Failure seems unrelated
   - [CI j8](https://app.circleci.com/pipelines/github/bereng/cassandra/52/workflows/16e15155-7dce-4877-86f5-315c6a837d36) Seems to be a new flaky tests but unrelated to the PR imo
   - Run on [cassandra13](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/156/) with some flakyness
   - Run on [another node](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/157/) is stable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng closed pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng closed pull request #652:
URL: https://github.com/apache/cassandra/pull/652


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] snazy commented on a change in pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
snazy commented on a change in pull request #652:
URL: https://github.com/apache/cassandra/pull/652#discussion_r449453360



##########
File path: conf/cassandra.yaml
##########
@@ -630,7 +630,8 @@ ssl_storage_port: 7001
 # Leaving it blank leaves it up to InetAddress.getLocalHost(). This
 # will always do the Right Thing _if_ the node is properly configured
 # (hostname, name resolution, etc), and the Right Thing is to use the
-# address associated with the hostname (it might not be).
+# address associated with the hostname (it might not be). If unresolvable
+# it will get InetAddress.getLoopbackAddress()

Review comment:
       ```suggestion
   # it will fall back to InetAddress.getLoopbackAddress(), which is wrong for production systems.
   ```

##########
File path: src/java/org/apache/cassandra/utils/FBUtilities.java
##########
@@ -130,16 +130,24 @@ public static MessageDigest newMessageDigest(String algorithm)
     public static InetAddress getJustLocalAddress()
     {
         if (localInetAddress == null)
-            try
-            {
-                localInetAddress = DatabaseDescriptor.getListenAddress() == null
-                                    ? InetAddress.getLocalHost()
-                                    : DatabaseDescriptor.getListenAddress();
-            }
-            catch (UnknownHostException e)
+        {
+            if (DatabaseDescriptor.getListenAddress() == null)
             {
-                throw new RuntimeException(e);
+                try
+                {
+                    localInetAddress = InetAddress.getLocalHost();
+                }
+                catch(UnknownHostException e)
+                {
+                    logger.info("InetAddress.getLocalHost() could not resolve, please check your node's config. Falling back to {}",
+                                InetAddress.getLoopbackAddress());

Review comment:
       ```suggestion
                                  e, InetAddress.getLoopbackAddress());
   ```

##########
File path: src/java/org/apache/cassandra/utils/FBUtilities.java
##########
@@ -130,16 +130,24 @@ public static MessageDigest newMessageDigest(String algorithm)
     public static InetAddress getJustLocalAddress()
     {
         if (localInetAddress == null)
-            try
-            {
-                localInetAddress = DatabaseDescriptor.getListenAddress() == null
-                                    ? InetAddress.getLocalHost()
-                                    : DatabaseDescriptor.getListenAddress();
-            }
-            catch (UnknownHostException e)
+        {
+            if (DatabaseDescriptor.getListenAddress() == null)
             {
-                throw new RuntimeException(e);
+                try
+                {
+                    localInetAddress = InetAddress.getLocalHost();
+                }
+                catch(UnknownHostException e)
+                {
+                    logger.info("InetAddress.getLocalHost() could not resolve, please check your node's config. Falling back to {}",

Review comment:
       ```suggestion
                       logger.info("InetAddress.getLocalHost() could not resolve the address for the hostname ({}), please check your node's config and set the listen_address in cassandra.yaml. Falling back to {}",
   ```

##########
File path: src/java/org/apache/cassandra/utils/FBUtilities.java
##########
@@ -130,16 +130,24 @@ public static MessageDigest newMessageDigest(String algorithm)
     public static InetAddress getJustLocalAddress()
     {
         if (localInetAddress == null)
-            try
-            {
-                localInetAddress = DatabaseDescriptor.getListenAddress() == null
-                                    ? InetAddress.getLocalHost()
-                                    : DatabaseDescriptor.getListenAddress();
-            }
-            catch (UnknownHostException e)
+        {
+            if (DatabaseDescriptor.getListenAddress() == null)
             {
-                throw new RuntimeException(e);
+                try
+                {
+                    localInetAddress = InetAddress.getLocalHost();

Review comment:
       ```suggestion
                       localInetAddress = InetAddress.getLocalHost();
                       logger.info("InetAddress.getLocalHost() was used to resolve listen_address to {}, this can cause issues. Please check your node's config and set the listen_address in cassandra.yaml.", localInetAddress);
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #652:
URL: https://github.com/apache/cassandra/pull/652#issuecomment-654155772


   CI runs:
   
   [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/44042930-ea9f-4b02-88d6-91b36d1d9bd6):
   - j8unit ActiveRepairServiceTest: Passes locally, ConnectionTest: [Known](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/) offender
   - j8_dtests-no-vnodes TestTransientReplicationRing looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest-novnode.transient_replication_ring_test/TestTransientReplicationRing/test_remove/history/) and passes locally
   - j8_dtests-with-vnodes TestIncRepair [known](https://issues.apache.org/jira/browse/CASSANDRA-15894) offender
   - j11unit ValidationExecutorTest passes locally
   - j11 dtests-with-vnodes test_manual_session_force_cancel passes locally, [test_restart_node_localhost](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest.pushed_notifications_test/TestPushedNotifications/test_restart_node_localhost/) known offender
   
   [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a)
   - j11unit testNoTreesRetainedAfterDifference passes locally
   - j11jvm_dtest Weird VM [failure](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a/jobs/544) and passes locally
   - dtests-no-vnodes: test_repaired_tracking_with_partition_deletes passes locally
   
   Ci-cass juni one [weird](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/165/) VM failure, unrelated?
   
   Waiting on ci-cass to complete the full run. Will update with results later
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng edited a comment on pull request #652: Cassandra 15901

Posted by GitBox <gi...@apache.org>.
bereng edited a comment on pull request #652:
URL: https://github.com/apache/cassandra/pull/652#issuecomment-654155772


   CI runs:
   
   [j8](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/44042930-ea9f-4b02-88d6-91b36d1d9bd6):
   - j8unit ActiveRepairServiceTest: Passes locally, ConnectionTest: [Known](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/) offender
   - j8_dtests-no-vnodes TestTransientReplicationRing looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest-novnode.transient_replication_ring_test/TestTransientReplicationRing/test_remove/history/) and passes locally
   - j8_dtests-with-vnodes TestIncRepair [known](https://issues.apache.org/jira/browse/CASSANDRA-15894) offender
   - j11unit ValidationExecutorTest passes locally
   - j11 dtests-with-vnodes test_manual_session_force_cancel passes locally, [test_restart_node_localhost](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/dtest.pushed_notifications_test/TestPushedNotifications/test_restart_node_localhost/) known offender
   
   [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a)
   - j11unit testNoTreesRetainedAfterDifference passes locally
   - j11jvm_dtest Weird VM [failure](https://app.circleci.com/pipelines/github/bereng/cassandra/59/workflows/f144b763-38e8-4fd5-b380-eaa6df88a59a/jobs/544) and passes locally
   - dtests-no-vnodes: test_repaired_tracking_with_partition_deletes passes locally
   
   Ci-cass juni one [weird](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/165/) VM failure, unrelated?
   
   Waiting on [ci-cass](https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/196/) to complete the full run. Will update with results later:
   - [ChecksummingTransformerTest](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cdc/126/testReport/junit/org.apache.cassandra.transport.frame.checksum/ChecksummingTransformerTest/corruptionCausesFailure_cdc/) I have seen this fail locally and looks [flaky](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.transport.frame.checksum/ChecksummingTransformerTest/history/)
   - [LongSharedExecutorPoolTest.testPromptnessOfExecution](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-burn/131/testReport/junit/org.apache.cassandra.concurrent/LongSharedExecutorPoolTest/testPromptnessOfExecution/) passes locally
   - [testMessagePurging-compression](https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-compression/128/testReport/junit/org.apache.cassandra.net/ConnectionTest/testMessagePurging_compression/) known [offender](https://ci-cassandra.apache.org/job/Cassandra-trunk/202/testReport/org.apache.cassandra.net/ConnectionTest/testMessagePurging/history/) also locally
   - TestPushedNotifications.test_restart_node_localhost is a known failure [CASSANDRA-15912](https://issues.apache.org/jira/browse/CASSANDRA-15912)
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org