[GitHub] [incubator-pinot] npawar commented on a change in pull request #3912: Fix SegmentGeneratorConfig where the time format in schema is not picked up

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #3912: Fix SegmentGeneratorConfig where the time format in schema is not picked up
URL: https://github.com/apache/incubator-pinot/pull/3912#discussion_r263182259
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java
 ##########
 @@ -382,11 +382,7 @@ public void setSegmentNamePostfix(String postfix) {
   }
 
   public String getTimeColumnName() {
-    if (_segmentTimeColumnName != null) {
-      return _segmentTimeColumnName;
-    }
-    // TODO: if segmentTimeColumnName is null, getQualifyingFields DATETIME. If multiple found, throw exception "must specify primary timeColumnName"
 
 Review comment:
   this looks fine to me. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org