You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/10/07 00:29:02 UTC
[GitHub] [hbase] apurtell opened a new pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
apurtell opened a new pull request #3730:
URL: https://github.com/apache/hbase/pull/3730
We get and retain Compressor instances in HFileBlockDefaultEncodingContext, and could in theory call Compressor#reinit when setting up the context, to update compression parameters like level and buffer size, but we do not plumb through the CompoundConfiguration from the Store into the encoding context. As a consequence we can only update codec parameters globally in system site conf files.
Fine grained configurability is important for algorithms like ZStandard (ZSTD), which offers more than 20 compression levels, where at level 1 it is almost as fast as LZ4, and where at levels >= 19 it utilizes computationally expensive techniques to rival LZMA at compression ratio but trades off significantly for reduced compresson throughput. The ZSTD
level that should be set for a given column family or table will vary by
use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#discussion_r732140320
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
##########
@@ -87,8 +92,24 @@ public void prepareDecoding(int onDiskSizeWithoutHeader, int uncompressedSizeWit
Compression.Algorithm compression = fileContext.getCompression();
if (compression != Compression.Algorithm.NONE) {
- Compression.decompress(blockBufferWithoutHeader, dataInputStream,
- uncompressedSizeWithoutHeader, compression);
+ Decompressor decompressor = null;
+ try {
+ decompressor = compression.getDecompressor();
+ // Some algorithms don't return decompressors and accept null as a valid parameter for
+ // same when creating decompression streams. We can ignore these cases wrt reinit.
+ if (decompressor != null && decompressor instanceof CanReinit) {
Review comment:
I didn't know that, cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-939129522
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 2s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 2s | master passed |
| +1 :green_heart: | compile | 3m 26s | master passed |
| +1 :green_heart: | shadedjars | 9m 8s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 27s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 1s | the patch passed |
| +1 :green_heart: | compile | 3m 31s | the patch passed |
| +1 :green_heart: | javac | 3m 31s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 27s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 35s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 205m 46s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 22s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 40s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-zstd in the patch passed. |
| | | 258m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f37e6d243f34 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a384c239b9 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/testReport/ |
| Max. process+thread count | 3364 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937381939
Confirmed functionality with a single host cluster:
hbase> create "IntegrationTestLoadCommonCrawl", \
{ NAME => 'c', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 131072 }, \
{ NAME => 'i', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 8192 }, \
CONFIGURATION => { 'hbase.io.compress.zstd.level' => '1' }
Loaded one WARC from common crawl.
Major compaction takes 11 seconds.
hbase> alter "IntegrationTestLoadCommonCrawl", \
CONFIGURATION => {'hbase.io.compress.zstd.level' => '10' }
Major compaction now takes 42 seconds. Total size on disk reduced by 11.6%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938031092
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 10s | master passed |
| +1 :green_heart: | compile | 6m 26s | master passed |
| +1 :green_heart: | checkstyle | 2m 29s | master passed |
| +1 :green_heart: | spotbugs | 5m 23s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 7s | the patch passed |
| +1 :green_heart: | compile | 6m 25s | the patch passed |
| +1 :green_heart: | javac | 6m 25s | the patch passed |
| -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 3 new + 38 unchanged - 2 fixed = 41 total (was 40) |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 19m 56s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 6m 45s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 22s | The patch does not generate ASF License warnings. |
| | | 70m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 73a391cd3ceb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 39a20c528e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-947024266
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 27s | Docker mode activated. |
| -1 :x: | patch | 0m 2s | https://github.com/apache/hbase/pull/3730 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/11/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937565243
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 29s | master passed |
| +1 :green_heart: | compile | 3m 9s | master passed |
| +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 20s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | the patch passed |
| +1 :green_heart: | compile | 3m 15s | the patch passed |
| +1 :green_heart: | javac | 3m 15s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 19s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 17s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 52s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 149m 15s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 14s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 1s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 2s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 41s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 58s | hbase-compression-zstd in the patch passed. |
| | | 198m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6bad53e2ef71 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/testReport/ |
| Max. process+thread count | 3917 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938875365
The test failures are not related and appear environmental in nature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946361174
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 1s | master passed |
| +1 :green_heart: | compile | 3m 35s | master passed |
| +1 :green_heart: | shadedjars | 8m 25s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 34s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | the patch passed |
| +1 :green_heart: | compile | 3m 34s | the patch passed |
| +1 :green_heart: | javac | 3m 34s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 59s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -0 :warning: | javadoc | 0m 44s | hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 5s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 163m 42s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 11m 56s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 1m 16s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 42s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-compression-zstd in the patch passed. |
| | | 228m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 83b21fd70bc9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 26ab9d0e0b |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/testReport/ |
| Max. process+thread count | 4457 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946305669
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 20s | master passed |
| +1 :green_heart: | compile | 6m 53s | master passed |
| +1 :green_heart: | checkstyle | 2m 47s | master passed |
| +1 :green_heart: | spotbugs | 5m 53s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 14s | the patch passed |
| +1 :green_heart: | compile | 6m 51s | the patch passed |
| +1 :green_heart: | javac | 6m 51s | the patch passed |
| -0 :warning: | checkstyle | 0m 24s | hbase-common: The patch generated 1 new + 1 unchanged - 2 fixed = 2 total (was 3) |
| +1 :green_heart: | checkstyle | 1m 12s | hbase-server: The patch generated 0 new + 88 unchanged - 2 fixed = 88 total (was 90) |
| +1 :green_heart: | checkstyle | 0m 19s | The patch passed checkstyle in hbase-mapreduce |
| +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-compression-aircompressor |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-lz4 |
| +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-compression-snappy |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-xz |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-zstd |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 21m 15s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 7m 24s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 23s | The patch does not generate ASF License warnings. |
| | | 76m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a565defc0648 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 26ab9d0e0b |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-947023581
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -1 :x: | patch | 0m 4s | https://github.com/apache/hbase/pull/3730 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/11/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/11/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-939101811
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 25s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 48s | master passed |
| +1 :green_heart: | compile | 3m 8s | master passed |
| +1 :green_heart: | shadedjars | 8m 14s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 20s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 56s | the patch passed |
| +1 :green_heart: | compile | 3m 7s | the patch passed |
| +1 :green_heart: | javac | 3m 7s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 20s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 49s | hbase-common in the patch passed. |
| -1 :x: | unit | 149m 29s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 1m 17s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 3s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 43s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-zstd in the patch passed. |
| | | 197m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux aaa71544e183 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a384c239b9 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/testReport/ |
| Max. process+thread count | 3923 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938275625
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 58s | master passed |
| +1 :green_heart: | compile | 3m 28s | master passed |
| +1 :green_heart: | shadedjars | 9m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 26s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 4s | the patch passed |
| +1 :green_heart: | compile | 3m 29s | the patch passed |
| +1 :green_heart: | javac | 3m 29s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 33s | hbase-common in the patch passed. |
| -1 :x: | unit | 211m 4s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 1m 27s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 55s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 41s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 58s | hbase-compression-zstd in the patch passed. |
| | | 264m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 552e6ed6c312 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 39a20c528e |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/testReport/ |
| Max. process+thread count | 3644 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937446655
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 31s | master passed |
| +1 :green_heart: | compile | 3m 1s | master passed |
| +1 :green_heart: | shadedjars | 9m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 16s | the patch passed |
| +1 :green_heart: | compile | 2m 59s | the patch passed |
| +1 :green_heart: | javac | 2m 59s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 7s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 10s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 52s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 221m 15s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 23s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 41s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-zstd in the patch passed. |
| | | 270m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 07ca7d10679f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/testReport/ |
| Max. process+thread count | 3359 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell merged pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell merged pull request #3730:
URL: https://github.com/apache/hbase/pull/3730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938875365
The test failures are not related and appear environmental in nature.
[ERROR] org.apache.hadoop.hbase.quotas.TestQuotaAdmin.null
[ERROR] Run 1: TestQuotaAdmin.testSetModifyRemoveRPCQuota:503 » TestTimedOut test timed out a...
[ERROR] Run 2: TestQuotaAdmin » Appears to be stuck in thread MiniHBaseClusterRegionServer-E...
[ERROR] Run 3: TestQuotaAdmin.setUpBeforeClass:99 » IllegalState A mini-cluster is already ru...
[ERROR] TestQuotaAdmin.clearQuotaTable:106 » TimeoutIO java.util.concurrent.TimeoutExc...
[ERROR] org.apache.hadoop.hbase.quotas.TestQuotaAdmin.testSetModifyRemoveRPCQuota
[ERROR] Run 1: TestQuotaAdmin.testSetModifyRemoveRPCQuota:503 » InterruptedIO
[ERROR] Run 2: TestQuotaAdmin.clearQuotaTable:106 » TableNotEnabled org.apache.hadoop.hbase.T...
[WARNING] org.apache.hadoop.hbase.TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry
[ERROR] Run 1: TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry:199
[INFO] Run 2: PASS
I ran the tests locally with this change applied and they passed. TestQuotaAdmin seems like a resource intensive unit (has a running time of 86 seconds on my macbook) and maybe we should break it up.
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.quotas.TestQuotaAdmin
[INFO] Running org.apache.hadoop.hbase.TestZooKeeper
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.494 s - in org.apache.hadoop.hbase.TestZooKeeper
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.059 s - in org.apache.hadoop.hbase.quotas.TestQuotaAdmin
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938875365
The test failures are not related and appear environmental in nature.
[ERROR] org.apache.hadoop.hbase.quotas.TestQuotaAdmin.null
[ERROR] Run 1: TestQuotaAdmin.testSetModifyRemoveRPCQuota:503 » TestTimedOut test timed out a...
[ERROR] Run 2: TestQuotaAdmin » Appears to be stuck in thread MiniHBaseClusterRegionServer-E...
[ERROR] Run 3: TestQuotaAdmin.setUpBeforeClass:99 » IllegalState A mini-cluster is already ru...
[ERROR] TestQuotaAdmin.clearQuotaTable:106 » TimeoutIO java.util.concurrent.TimeoutExc...
[ERROR] org.apache.hadoop.hbase.quotas.TestQuotaAdmin.testSetModifyRemoveRPCQuota
[ERROR] Run 1: TestQuotaAdmin.testSetModifyRemoveRPCQuota:503 » InterruptedIO
[ERROR] Run 2: TestQuotaAdmin.clearQuotaTable:106 » TableNotEnabled org.apache.hadoop.hbase.T...
[WARNING] org.apache.hadoop.hbase.TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry
[ERROR] Run 1: TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry:199
[INFO] Run 2: PASS
I ran the tests locally with this change applied and they passed. TestQuotaAdmin seems like a resource intensive unit and maybe we should break it up.
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.quotas.TestQuotaAdmin
[INFO] Running org.apache.hadoop.hbase.TestZooKeeper
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.494 s - in org.apache.hadoop.hbase.TestZooKeeper
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.059 s - in org.apache.hadoop.hbase.quotas.TestQuotaAdmin
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937447858
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/3730 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946382971
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 8m 13s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 35s | master passed |
| +1 :green_heart: | compile | 4m 27s | master passed |
| +1 :green_heart: | shadedjars | 9m 29s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 1s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 13s | the patch passed |
| +1 :green_heart: | compile | 4m 18s | the patch passed |
| +1 :green_heart: | javac | 4m 18s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 14s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 24s | hbase-common generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) |
| -0 :warning: | javadoc | 0m 43s | hbase-server generated 1 new + 86 unchanged - 0 fixed = 87 total (was 86) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 49s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 208m 4s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 15m 17s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 1m 21s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 41s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-zstd in the patch passed. |
| | | 288m 34s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux e63391308825 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 26ab9d0e0b |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/testReport/ |
| Max. process+thread count | 3708 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/10/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937376677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-940434701
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 45s | master passed |
| +1 :green_heart: | compile | 3m 4s | master passed |
| +1 :green_heart: | shadedjars | 8m 25s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 21s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 41s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 29s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 58s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 159m 8s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 19s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 3s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 44s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-zstd in the patch passed. |
| | | 207m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7f1c1482e811 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ce44e16939 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/testReport/ |
| Max. process+thread count | 3930 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937836914
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 14s | master passed |
| +1 :green_heart: | compile | 3m 56s | master passed |
| +1 :green_heart: | shadedjars | 9m 37s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 53s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 52s | the patch passed |
| +1 :green_heart: | compile | 3m 57s | the patch passed |
| +1 :green_heart: | javac | 3m 57s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 54s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 40s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 41s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 222m 32s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 32s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 7s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 17s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 51s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-zstd in the patch passed. |
| | | 281m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux edc44e53602c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/testReport/ |
| Max. process+thread count | 3450 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938164251
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 36s | master passed |
| +1 :green_heart: | compile | 3m 50s | master passed |
| +1 :green_heart: | shadedjars | 9m 30s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 42s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 13s | the patch passed |
| +1 :green_heart: | compile | 3m 40s | the patch passed |
| +1 :green_heart: | javac | 3m 40s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 16s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 32s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 39s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 209m 38s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 23s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 55s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 41s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-zstd in the patch passed. |
| | | 265m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f6e25384d6c0 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 39a20c528e |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/testReport/ |
| Max. process+thread count | 3724 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937979101
Rebase and update commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937674446
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 14s | master passed |
| +1 :green_heart: | compile | 6m 10s | master passed |
| +1 :green_heart: | checkstyle | 2m 24s | master passed |
| +1 :green_heart: | spotbugs | 5m 7s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 14s | the patch passed |
| +1 :green_heart: | compile | 6m 6s | the patch passed |
| +1 :green_heart: | javac | 6m 6s | the patch passed |
| -0 :warning: | checkstyle | 1m 8s | hbase-server: The patch generated 3 new + 38 unchanged - 2 fixed = 41 total (was 40) |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 21m 17s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 6m 32s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. |
| | | 71m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 61f48a5e5e65 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946069284
@virajjasani @Apache9 This PR is blocking https://github.com/apache/hbase/pull/3748, which has been approved for merge.
I refactored the changes of #3748 and this PR to make #3748 smaller and collect all of the the changes for plumbing `Configuration` through to block encoder and decoder contexts into this one, so they are all in one place. The changes here have been tested on/for #3748. Custom dictionary specified in table schema works as advertised. Will add a unit test for it on #3748.
There might be another round of checkstyle fixes needed. Will apply them as soon as the precommit report is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-939130107
More unstable tests, but they do not seem related to this change:
One error
[ERROR] org.apache.hadoop.hbase.master.TestSplitRegionWhileRSCrash.null
[ERROR] Run 1: TestSplitRegionWhileRSCrash.test:106 » TestTimedOut test timed out after 780 s...
[ERROR] Run 2: TestSplitRegionWhileRSCrash » Appears to be stuck in thread MiniHBaseClusterR...
Three flakes:
[WARNING] org.apache.hadoop.hbase.client.TestSeparateClientZKCluster.testBasicOperation
[ERROR] Run 1: TestSeparateClientZKCluster.testBasicOperation:113 » DoNotRetryIO Unable to in...
[INFO] Run 2: PASS
[WARNING] org.apache.hadoop.hbase.client.TestSeparateClientZKCluster.testMasterSwitch
[ERROR] Run 1: TestSeparateClientZKCluster.testMasterSwitch:147 » RetriesExhausted Failed aft...
[INFO] Run 2: PASS
[WARNING] org.apache.hadoop.hbase.client.TestSeparateClientZKCluster.testMetaMoveDuringClientZkClusterRestart
[ERROR] Run 1: TestSeparateClientZKCluster.testMetaMoveDuringClientZkClusterRestart:213 » DoNotRetryIO
[INFO] Run 2: PASS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938875365
The test failures are not related and appear environmental in nature.
[ERROR] org.apache.hadoop.hbase.quotas.TestQuotaAdmin.null
[ERROR] Run 1: TestQuotaAdmin.testSetModifyRemoveRPCQuota:503 » TestTimedOut test timed out a...
[ERROR] Run 2: TestQuotaAdmin » Appears to be stuck in thread MiniHBaseClusterRegionServer-E...
[ERROR] Run 3: TestQuotaAdmin.setUpBeforeClass:99 » IllegalState A mini-cluster is already ru...
[ERROR] TestQuotaAdmin.clearQuotaTable:106 » TimeoutIO java.util.concurrent.TimeoutExc...
[ERROR] org.apache.hadoop.hbase.quotas.TestQuotaAdmin.testSetModifyRemoveRPCQuota
[ERROR] Run 1: TestQuotaAdmin.testSetModifyRemoveRPCQuota:503 » InterruptedIO
[ERROR] Run 2: TestQuotaAdmin.clearQuotaTable:106 » TableNotEnabled org.apache.hadoop.hbase.T...
[WARNING] org.apache.hadoop.hbase.TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry
[ERROR] Run 1: TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry:199
[INFO] Run 2: PASS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937381939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937376677
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 30s | master passed |
| +1 :green_heart: | compile | 7m 48s | master passed |
| +1 :green_heart: | checkstyle | 2m 27s | master passed |
| +1 :green_heart: | spotbugs | 5m 8s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 17s | the patch passed |
| +1 :green_heart: | compile | 6m 5s | the patch passed |
| +1 :green_heart: | javac | 6m 5s | the patch passed |
| -0 :warning: | checkstyle | 1m 9s | hbase-server: The patch generated 3 new + 38 unchanged - 2 fixed = 41 total (was 40) |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 21m 26s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 6m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 14s | The patch does not generate ASF License warnings. |
| | | 73m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3dcff23d9ad0 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946133177
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 1s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 55s | master passed |
| +1 :green_heart: | compile | 7m 6s | master passed |
| +1 :green_heart: | checkstyle | 2m 43s | master passed |
| +1 :green_heart: | spotbugs | 6m 0s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 7m 16s | the patch passed |
| +1 :green_heart: | javac | 7m 16s | the patch passed |
| -0 :warning: | checkstyle | 0m 24s | hbase-common: The patch generated 1 new + 1 unchanged - 2 fixed = 2 total (was 3) |
| +1 :green_heart: | checkstyle | 1m 0s | hbase-server: The patch generated 0 new + 88 unchanged - 2 fixed = 88 total (was 90) |
| +1 :green_heart: | checkstyle | 0m 19s | The patch passed checkstyle in hbase-mapreduce |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-compression-aircompressor |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-compression-lz4 |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-compression-snappy |
| +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-compression-xz |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-compression-zstd |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 23m 43s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 9m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 45s | The patch does not generate ASF License warnings. |
| | | 82m 57s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 15edd5bfb4e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4454c2f909 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946216146
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 51s | master passed |
| +1 :green_heart: | compile | 4m 3s | master passed |
| +1 :green_heart: | shadedjars | 8m 39s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 3s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 37s | the patch passed |
| +1 :green_heart: | compile | 4m 8s | the patch passed |
| +1 :green_heart: | javac | 4m 8s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 46s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 25s | hbase-common generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) |
| -0 :warning: | javadoc | 0m 41s | hbase-server generated 1 new + 86 unchanged - 0 fixed = 87 total (was 86) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 13s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 142m 29s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 11m 12s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 1m 13s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 0s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 3s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 41s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 3s | hbase-compression-zstd in the patch passed. |
| | | 208m 1s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d2d0c5d50680 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4454c2f909 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/testReport/ |
| Max. process+thread count | 4089 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937445529
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 59s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 16s | master passed |
| +1 :green_heart: | compile | 3m 27s | master passed |
| +1 :green_heart: | shadedjars | 9m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 4s | the patch passed |
| +1 :green_heart: | compile | 3m 29s | the patch passed |
| +1 :green_heart: | javac | 3m 29s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 1s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 34s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 214m 4s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 25s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 55s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 51s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 1s | hbase-compression-zstd in the patch passed. |
| | | 267m 35s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6d5817234044 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/testReport/ |
| Max. process+thread count | 3362 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937381939
Confirmed functionality with a single host cluster:
hbase> create "IntegrationTestLoadCommonCrawl", \
{ NAME => 'c', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 131072 }, \
{ NAME => 'i', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 8192 }, \
CONFIGURATION => { 'hbase.io.compress.zstd.level' => '1' }
Loaded one WARC from common crawl.
Major compaction takes 11 seconds.
hbase> alter "IntegrationTestLoadCommonCrawl", \
CONFIGURATION => {'hbase.io.compress.zstd.level' => '10' }
Major compaction now takes 42 seconds. Total size on disk reduced by 11.6%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938203515
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 7s | master passed |
| +1 :green_heart: | compile | 6m 14s | master passed |
| +1 :green_heart: | checkstyle | 2m 29s | master passed |
| +1 :green_heart: | spotbugs | 5m 11s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 46s | the patch passed |
| +1 :green_heart: | compile | 6m 16s | the patch passed |
| +1 :green_heart: | javac | 6m 16s | the patch passed |
| -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 3 new + 38 unchanged - 2 fixed = 41 total (was 40) |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 19m 34s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 6m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 30s | The patch does not generate ASF License warnings. |
| | | 69m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 22ebbd29245a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 39a20c528e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-939038291
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 29s | master passed |
| +1 :green_heart: | compile | 6m 11s | master passed |
| +1 :green_heart: | checkstyle | 2m 26s | master passed |
| +1 :green_heart: | spotbugs | 5m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 17s | the patch passed |
| +1 :green_heart: | compile | 6m 10s | the patch passed |
| +1 :green_heart: | javac | 6m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 24s | The patch passed checkstyle in hbase-common |
| +1 :green_heart: | checkstyle | 1m 9s | hbase-server: The patch generated 0 new + 38 unchanged - 2 fixed = 38 total (was 40) |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-aircompressor |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-lz4 |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-snappy |
| +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-compression-xz |
| +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-compression-zstd |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 21m 21s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 6m 32s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 15s | The patch does not generate ASF License warnings. |
| | | 72m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 74526ac8b67a 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a384c239b9 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/6/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-939130447
Let me run these types of tests in a loop locally just to double check...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938900115
Rebase. Fix checkstyle warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946216729
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 44s | master passed |
| +1 :green_heart: | compile | 3m 25s | master passed |
| +1 :green_heart: | shadedjars | 8m 9s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 51s | the patch passed |
| +1 :green_heart: | compile | 3m 32s | the patch passed |
| +1 :green_heart: | javac | 3m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 7s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 21s | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -0 :warning: | javadoc | 0m 36s | hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 50s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 149m 21s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 10m 59s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | unit | 1m 17s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 44s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-compression-zstd in the patch passed. |
| | | 209m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 8a5bb6b14108 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4454c2f909 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/testReport/ |
| Max. process+thread count | 4744 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-mapreduce hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/9/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#discussion_r732140690
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
##########
@@ -87,8 +92,24 @@ public void prepareDecoding(int onDiskSizeWithoutHeader, int uncompressedSizeWit
Compression.Algorithm compression = fileContext.getCompression();
if (compression != Compression.Algorithm.NONE) {
- Compression.decompress(blockBufferWithoutHeader, dataInputStream,
- uncompressedSizeWithoutHeader, compression);
+ Decompressor decompressor = null;
+ try {
+ decompressor = compression.getDecompressor();
+ // Some algorithms don't return decompressors and accept null as a valid parameter for
+ // same when creating decompression streams. We can ignore these cases wrt reinit.
+ if (decompressor != null && decompressor instanceof CanReinit) {
+ ((CanReinit)decompressor).reinit(conf);
+ }
+ try (InputStream is =
+ compression.createDecompressionStream(dataInputStream, decompressor, 0)) {
+ BlockIOUtils.readFullyWithHeapBuffer(is, blockBufferWithoutHeader,
+ uncompressedSizeWithoutHeader);
+ }
+ } finally {
+ if (decompressor != null) {
+ compression.returnDecompressor(decompressor);
+ }
+ }
Review comment:
Sure, it is not being used, I think removal is a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946275909
Rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937822159
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 24s | master passed |
| +1 :green_heart: | compile | 2m 59s | master passed |
| +1 :green_heart: | shadedjars | 9m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 11s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 18s | the patch passed |
| +1 :green_heart: | compile | 3m 5s | the patch passed |
| +1 :green_heart: | javac | 3m 5s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 53s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 215m 59s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 23s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 40s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-zstd in the patch passed. |
| | | 265m 42s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 1f6bf01db6bb 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/testReport/ |
| Max. process+thread count | 3289 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938252749
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 23s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 48s | master passed |
| +1 :green_heart: | compile | 3m 5s | master passed |
| +1 :green_heart: | shadedjars | 8m 20s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 22s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 53s | the patch passed |
| +1 :green_heart: | compile | 3m 5s | the patch passed |
| +1 :green_heart: | javac | 3m 5s | the patch passed |
| +1 :green_heart: | shadedjars | 8m 18s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 49s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 149m 29s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 23s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 3s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 43s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-zstd in the patch passed. |
| | | 197m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 31c933107d97 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 39a20c528e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/testReport/ |
| Max. process+thread count | 4344 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/5/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937381939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-940490726
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 14s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 58s | master passed |
| +1 :green_heart: | compile | 3m 29s | master passed |
| +1 :green_heart: | shadedjars | 9m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 27s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 3s | the patch passed |
| +1 :green_heart: | compile | 3m 32s | the patch passed |
| +1 :green_heart: | javac | 3m 32s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 23s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 31s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 39s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 240m 19s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 24s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 54s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 40s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 58s | hbase-compression-zstd in the patch passed. |
| | | 299m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 474cac89ee64 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ce44e16939 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/testReport/ |
| Max. process+thread count | 3080 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-946047529
Test failures are not related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937619620
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 17s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 7s | master passed |
| +1 :green_heart: | compile | 3m 36s | master passed |
| +1 :green_heart: | shadedjars | 9m 22s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 27s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 0s | the patch passed |
| +1 :green_heart: | compile | 3m 33s | the patch passed |
| +1 :green_heart: | javac | 3m 33s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 6s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 35s | hbase-common in the patch passed. |
| -1 :x: | unit | 215m 42s | hbase-server in the patch failed. |
| +1 :green_heart: | unit | 1m 23s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 42s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 0m 57s | hbase-compression-zstd in the patch passed. |
| | | 269m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 69f8aaa44c24 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 42fe5e5baa |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/testReport/ |
| Max. process+thread count | 3580 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell edited a comment on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937381939
Confirmed functionality with a single host cluster:
hbase> create "IntegrationTestLoadCommonCrawl", \
{ NAME => 'c', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 131072 }, \
{ NAME => 'i', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 8192 }, \
CONFIGURATION => { 'hbase.io.compress.zstd.level' => '1' }
Loaded one WARC from common crawl.
Major compaction takes 11 seconds.
hbase> alter "IntegrationTestLoadCommonCrawl", \
CONFIGURATION => { 'hbase.io.compress.zstd.level' => '10' }
Major compaction now takes 42 seconds. Total size on disk reduced by 11.6% vs level 1.
hbase> alter "IntegrationTestLoadCommonCrawl", \
CONFIGURATION => { 'hbase.io.compress.zstd.level' => '22' }
Major compaction now takes 17 minutes 15 seconds. Total size on disk reduced by 13.3% vs level 1. (Sure, this level is crazy in practice.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-938132184
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 3s | master passed |
| +1 :green_heart: | compile | 3m 7s | master passed |
| +1 :green_heart: | shadedjars | 8m 19s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 55s | the patch passed |
| +1 :green_heart: | compile | 3m 5s | the patch passed |
| +1 :green_heart: | javac | 3m 5s | the patch passed |
| +1 :green_heart: | shadedjars | 9m 26s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 7s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 164m 43s | hbase-server in the patch passed. |
| +1 :green_heart: | unit | 1m 16s | hbase-compression-aircompressor in the patch passed. |
| +1 :green_heart: | unit | 1m 4s | hbase-compression-lz4 in the patch passed. |
| +1 :green_heart: | unit | 1m 6s | hbase-compression-snappy in the patch passed. |
| +1 :green_heart: | unit | 1m 43s | hbase-compression-xz in the patch passed. |
| +1 :green_heart: | unit | 1m 5s | hbase-compression-zstd in the patch passed. |
| | | 214m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f01f1a4c47a4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 39a20c528e |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/testReport/ |
| Max. process+thread count | 4013 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/4/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-937381939
Confirmed functionality with a single host cluster:
hbase> create "IntegrationTestLoadCommonCrawl", \
{ NAME => 'c', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 131072 }, \
{ NAME => 'i', VERSIONS => 1000, COMPRESSION => 'LZ4', COMPRESSION_COMPACT => 'ZSTD', BLOCKSIZE => 8192 }, \
CONFIGURATION => { 'hbase.io.compress.zstd.level' => '1' }
Loaded one WARC from common crawl. Major compaction takes 11 seconds.
hbase> alter "IntegrationTestLoadCommonCrawl", \
CONFIGURATION => {'hbase.io.compress.zstd.level' => '10' }
Major compaction now takes 42 seconds. Total size on disk reduced by 11.6%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#discussion_r732126323
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
##########
@@ -68,21 +70,24 @@
/**
* Create a buffer which will be encoded using dataBlockEncoder.
+ * @param conf store configuration
* @param dataBlockEncoder Algorithm used for compression.
* @param encoding encoding type used
- * @param rawKVs
- * @param meta
+ * @param rawKVs raw KVs
+ * @param meta hfile context
+ * @param conf store configuration
Review comment:
nit: looks like duplicate `@param`, it's already covered above
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/AbstractDataBlockEncoder.java
##########
@@ -29,14 +31,14 @@
public abstract class AbstractDataBlockEncoder implements DataBlockEncoder {
@Override
- public HFileBlockEncodingContext newDataBlockEncodingContext(
+ public HFileBlockEncodingContext newDataBlockEncodingContext(Configuration conf,
DataBlockEncoding encoding, byte[] header, HFileContext meta) {
- return new HFileBlockDefaultEncodingContext(encoding, header, meta);
+ return new HFileBlockDefaultEncodingContext(conf, encoding, header, meta);
}
@Override
- public HFileBlockDecodingContext newDataBlockDecodingContext(HFileContext meta) {
- return new HFileBlockDefaultDecodingContext(meta);
+ public HFileBlockDecodingContext newDataBlockDecodingContext(Configuration conf, HFileContext meta) {
Review comment:
nit: checkstyle line-length might complain
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
##########
@@ -87,8 +92,24 @@ public void prepareDecoding(int onDiskSizeWithoutHeader, int uncompressedSizeWit
Compression.Algorithm compression = fileContext.getCompression();
if (compression != Compression.Algorithm.NONE) {
- Compression.decompress(blockBufferWithoutHeader, dataInputStream,
- uncompressedSizeWithoutHeader, compression);
+ Decompressor decompressor = null;
+ try {
+ decompressor = compression.getDecompressor();
+ // Some algorithms don't return decompressors and accept null as a valid parameter for
+ // same when creating decompression streams. We can ignore these cases wrt reinit.
+ if (decompressor != null && decompressor instanceof CanReinit) {
Review comment:
Simplify to `decompressor instanceof CanReinit` as it covers null check also?
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
##########
@@ -87,8 +92,24 @@ public void prepareDecoding(int onDiskSizeWithoutHeader, int uncompressedSizeWit
Compression.Algorithm compression = fileContext.getCompression();
if (compression != Compression.Algorithm.NONE) {
- Compression.decompress(blockBufferWithoutHeader, dataInputStream,
- uncompressedSizeWithoutHeader, compression);
+ Decompressor decompressor = null;
+ try {
+ decompressor = compression.getDecompressor();
+ // Some algorithms don't return decompressors and accept null as a valid parameter for
+ // same when creating decompression streams. We can ignore these cases wrt reinit.
+ if (decompressor != null && decompressor instanceof CanReinit) {
+ ((CanReinit)decompressor).reinit(conf);
+ }
+ try (InputStream is =
+ compression.createDecompressionStream(dataInputStream, decompressor, 0)) {
+ BlockIOUtils.readFullyWithHeapBuffer(is, blockBufferWithoutHeader,
+ uncompressedSizeWithoutHeader);
+ }
+ } finally {
+ if (decompressor != null) {
+ compression.returnDecompressor(decompressor);
+ }
+ }
Review comment:
nit: shall we remove Compression#decompress method? After this change, perhaps it is not being used anywhere else, nothing urgent, can be follow up too if it creates complexities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3730: HBASE-26316 Per-table or per-CF compression codec setting overrides
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#issuecomment-940357345
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 6s | master passed |
| +1 :green_heart: | compile | 6m 9s | master passed |
| +1 :green_heart: | checkstyle | 2m 31s | master passed |
| +1 :green_heart: | spotbugs | 5m 10s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 48s | the patch passed |
| +1 :green_heart: | compile | 6m 28s | the patch passed |
| +1 :green_heart: | javac | 6m 28s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 26s | The patch passed checkstyle in hbase-common |
| +1 :green_heart: | checkstyle | 1m 5s | hbase-server: The patch generated 0 new + 38 unchanged - 2 fixed = 38 total (was 40) |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-compression-aircompressor |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-compression-lz4 |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-compression-snappy |
| +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-compression-xz |
| +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-compression-zstd |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 24m 2s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. |
| +1 :green_heart: | spotbugs | 7m 26s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 1m 24s | The patch does not generate ASF License warnings. |
| | | 75m 58s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3730 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux cb06d7134194 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ce44e16939 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-server hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3730/7/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org