[GitHub] [airflow] eladkal commented on a change in pull request #22395: Add timeout and retry to the BigQueryInsertJobOperator

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #22395:
URL: https://github.com/apache/airflow/pull/22395#discussion_r830860848



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -2052,6 +2053,8 @@ class BigQueryInsertJobOperator(BaseOperator):
         Service Account Token Creator IAM role to the directly preceding identity, with first
         account from the list granting this role to the originating account (templated).
     :param cancel_on_kill: Flag which indicates whether cancel the hook's job or not, when on_kill is called
+    :param retry: Designation of what errors, if any, should be retried.

Review comment:
       This may be very confusing with `retries` from `BaseOprerator`.
   
   ```
   BigQueryInsertJobOperator(
   ...,
   retry=3,
   retries=10
   )
   ```
   
   We need better name for it - I think. Something that the user will know that retries refer to BigQuery "internal" capability.
   
   I would say that the same goes for the `timeout`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org