You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/19 08:25:15 UTC

[kudu-CR] util: stop using namespaces

Hello Alexey Serbin, Andrew Wong, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15491

to review the following change.


Change subject: util: stop using namespaces
......................................................................

util: stop using namespaces

There were a few holdouts of this, most likely from imported Impala code.
It's a no-no for Kudu style, and "using namespace std" causes IWYU to
recommend including <__config> when run against libc++.

Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
---
M src/kudu/util/block_bloom_filter-test.cc
M src/kudu/util/logging.cc
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
4 files changed, 16 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/15491/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] util: stop using namespaces

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15491

to look at the new patch set (#2).

Change subject: util: stop using namespaces
......................................................................

util: stop using namespaces

There were a few holdouts of this, most likely from imported Impala code.
It's a no-no for Kudu style, and "using namespace std" causes IWYU to
recommend including <__config> when run against libc++.

Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
---
M src/kudu/util/block_bloom_filter-test.cc
M src/kudu/util/logging.cc
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
4 files changed, 16 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/15491/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] util: stop using namespaces

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15491 )

Change subject: util: stop using namespaces
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 08:27:06 +0000
Gerrit-HasComments: No

[kudu-CR] util: stop using namespaces

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/15491 )

Change subject: util: stop using namespaces
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] util: stop using namespaces

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15491 )

Change subject: util: stop using namespaces
......................................................................

util: stop using namespaces

There were a few holdouts of this, most likely from imported Impala code.
It's a no-no for Kudu style, and "using namespace std" causes IWYU to
recommend including <__config> when run against libc++.

Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Reviewed-on: http://gerrit.cloudera.org:8080/15491
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/block_bloom_filter-test.cc
M src/kudu/util/logging.cc
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.cc
4 files changed, 16 insertions(+), 11 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Adar Dembo: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] util: stop using namespaces

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15491 )

Change subject: util: stop using namespaces
......................................................................


Patch Set 2: Verified+1

Overriding Jenkins, failure was in the dist-test build directory.


-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 19:02:59 +0000
Gerrit-HasComments: No

[kudu-CR] util: stop using namespaces

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15491 )

Change subject: util: stop using namespaces
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 19:00:14 +0000
Gerrit-HasComments: No

[kudu-CR] util: stop using namespaces

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15491 )

Change subject: util: stop using namespaces
......................................................................


Patch Set 1: Code-Review+2

It seems IWYU is not happy, but probably that's because of prior changelist ?


-- 
To view, visit http://gerrit.cloudera.org:8080/15491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc50ca397c3384c79be2181ffb0e0133939c6c
Gerrit-Change-Number: 15491
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 15:43:14 +0000
Gerrit-HasComments: No