You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/07/08 19:38:45 UTC

[GitHub] [commons-io] robtimus opened a new pull request #123: CharSequenceReader.skip should return 0 instead of EOF on stream end

robtimus opened a new pull request #123:
URL: https://github.com/apache/commons-io/pull/123


   `Reader.skip(long n)` returns
   > The number of characters actually skipped
   
   The current implementation of `CharSequenceReader` instead returns `EOF`, which is -1. This should be 0, which is just what this PR changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #123: CharSequenceReader.skip should return 0 instead of EOF on stream end

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #123:
URL: https://github.com/apache/commons-io/pull/123


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] coveralls commented on pull request #123: CharSequenceReader.skip should return 0 instead of EOF on stream end

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #123:
URL: https://github.com/apache/commons-io/pull/123#issuecomment-655749312


   
   [![Coverage Status](https://coveralls.io/builds/31949824/badge)](https://coveralls.io/builds/31949824)
   
   Coverage increased (+0.06%) to 89.772% when pulling **1388450ff89f3ed517af1dab41bbb3486852d84c on robtimus:CharSequenceReader.skip** into **821ab5fc6140581d0dd4906c9cbcb721de0ec1fb on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] jochenw commented on pull request #123: CharSequenceReader.skip should return 0 instead of EOF on stream end

Posted by GitBox <gi...@apache.org>.
jochenw commented on pull request #123:
URL: https://github.com/apache/commons-io/pull/123#issuecomment-655928729


   Approving. This introduces a minor incompatibility, but I guess, that the skip method is rarely used, and the spec rules.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org