You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mdeshmu (via GitHub)" <gi...@apache.org> on 2023/05/21 06:22:17 UTC
[GitHub] [superset] mdeshmu opened a new pull request, #24157: Test pure sasl with hive python 3.9
mdeshmu opened a new pull request, #24157:
URL: https://github.com/apache/superset/pull/24157
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24157: Test pure sasl with hive python 3.9
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24157:
URL: https://github.com/apache/superset/pull/24157#issuecomment-1556096725
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24157?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24157](https://app.codecov.io/gh/apache/superset/pull/24157?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1f55781) into [master](https://app.codecov.io/gh/apache/superset/commit/1583090623c5083de504ad1e1710b894f0dc7f67?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1583090) will **decrease** coverage by `11.25%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 1f55781 differs from pull request most recent head e1df3b2. Consider uploading reports for the commit e1df3b2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24157 +/- ##
===========================================
- Coverage 68.27% 57.02% -11.25%
===========================================
Files 1952 1952
Lines 75367 75377 +10
Branches 8208 8208
===========================================
- Hits 51455 42986 -8469
- Misses 21806 30285 +8479
Partials 2106 2106
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.24% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `59.52% <100.00%> (-23.31%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.28% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/common/chart\_data.py](https://app.codecov.io/gh/apache/superset/pull/24157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbW9uL2NoYXJ0X2RhdGEucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_parse.py](https://app.codecov.io/gh/apache/superset/pull/24157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `95.41% <100.00%> (-1.10%)` | :arrow_down: |
... and [307 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24157/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24157: Test pure sasl with hive python 3.9
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24157:
URL: https://github.com/apache/superset/pull/24157#issuecomment-1557748861
@mdeshmu could you provide a detailed PR description so reviewers can better understand the intent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu closed pull request #24157: Test pure sasl with hive python 3.9
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu closed pull request #24157: Test pure sasl with hive python 3.9
URL: https://github.com/apache/superset/pull/24157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #24157: Test pure sasl with hive python 3.9
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #24157:
URL: https://github.com/apache/superset/pull/24157#issuecomment-1557758795
@john-bodley sorry for inconvenience. Added the summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org