You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2016/01/25 07:48:05 UTC

Review Request 42709: PIG-4690 Union with self replicate join will fail in Tez

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42709/
-----------------------------------------------------------

Review request for pig and Daniel Dai.


Bugs: PIG-4690
    https://issues.apache.org/jira/browse/PIG-4690


Repository: pig


Description
-------

Details in https://issues.apache.org/jira/browse/PIG-4690?focusedCommentId=15114827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15114827


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/MultiQueryOptimizerTez.java 1725329 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/TezOperDependencyParallelismEstimator.java 1725329 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java 1725329 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/builtin/GFCross.java 1725329 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Cross-3.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SelfJoin-4.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezCompiler.java 1725329 

Diff: https://reviews.apache.org/r/42709/diff/


Testing
-------


Thanks,

Rohini Palaniswamy


Re: Review Request 42709: PIG-4690 Union with self replicate join will fail in Tez

Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42709/#review117030
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Dai


On Jan. 29, 2016, 9:51 p.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42709/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 9:51 p.m.)
> 
> 
> Review request for pig and Daniel Dai.
> 
> 
> Bugs: PIG-4690
>     https://issues.apache.org/jira/browse/PIG-4690
> 
> 
> Repository: pig
> 
> 
> Description
> -------
> 
> Details in https://issues.apache.org/jira/browse/PIG-4690?focusedCommentId=15114827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15114827
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/MultiQueryOptimizerTez.java 1727439 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/TezOperDependencyParallelismEstimator.java 1727439 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java 1727439 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/builtin/GFCross.java 1727439 
>   http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/multiquery.conf 1727439 
>   http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/nightly.conf 1727439 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Cross-3.gld PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-8-OPTOFF.gld PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-8.gld PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SelfJoin-4.gld PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezCompiler.java 1727439 
> 
> Diff: https://reviews.apache.org/r/42709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>


Re: Review Request 42709: PIG-4690 Union with self replicate join will fail in Tez

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42709/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 9:51 p.m.)


Review request for pig and Daniel Dai.


Changes
-------

Had missed the new multiquery e2e test that I added from in the earlier diffs


Bugs: PIG-4690
    https://issues.apache.org/jira/browse/PIG-4690


Repository: pig


Description
-------

Details in https://issues.apache.org/jira/browse/PIG-4690?focusedCommentId=15114827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15114827


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/MultiQueryOptimizerTez.java 1727439 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/TezOperDependencyParallelismEstimator.java 1727439 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java 1727439 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/builtin/GFCross.java 1727439 
  http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/multiquery.conf 1727439 
  http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/nightly.conf 1727439 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Cross-3.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-8-OPTOFF.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-8.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SelfJoin-4.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezCompiler.java 1727439 

Diff: https://reviews.apache.org/r/42709/diff/


Testing
-------


Thanks,

Rohini Palaniswamy


Re: Review Request 42709: PIG-4690 Union with self replicate join will fail in Tez

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42709/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 4:46 p.m.)


Review request for pig and Daniel Dai.


Changes
-------

Added a couple more tests and fixed a condition


Bugs: PIG-4690
    https://issues.apache.org/jira/browse/PIG-4690


Repository: pig


Description
-------

Details in https://issues.apache.org/jira/browse/PIG-4690?focusedCommentId=15114827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15114827


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/MultiQueryOptimizerTez.java 1726579 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/TezOperDependencyParallelismEstimator.java 1726579 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java 1726579 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/builtin/GFCross.java 1726579 
  http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/nightly.conf 1726579 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Cross-3.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-8-OPTOFF.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-8.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SelfJoin-4.gld PRE-CREATION 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezCompiler.java 1726579 

Diff: https://reviews.apache.org/r/42709/diff/


Testing
-------


Thanks,

Rohini Palaniswamy


Re: Review Request 42709: PIG-4690 Union with self replicate join will fail in Tez

Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42709/#review116059
-----------------------------------------------------------


Ship it!




Ship It!

- Daniel Dai


On Jan. 25, 2016, 6:48 a.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42709/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 6:48 a.m.)
> 
> 
> Review request for pig and Daniel Dai.
> 
> 
> Bugs: PIG-4690
>     https://issues.apache.org/jira/browse/PIG-4690
> 
> 
> Repository: pig
> 
> 
> Description
> -------
> 
> Details in https://issues.apache.org/jira/browse/PIG-4690?focusedCommentId=15114827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15114827
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/MultiQueryOptimizerTez.java 1725329 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/TezOperDependencyParallelismEstimator.java 1725329 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/util/TezCompilerUtil.java 1725329 
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/builtin/GFCross.java 1725329 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Cross-3.gld PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SelfJoin-4.gld PRE-CREATION 
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezCompiler.java 1725329 
> 
> Diff: https://reviews.apache.org/r/42709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>