You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/05 15:03:50 UTC
[GitHub] [pulsar-helm-chart] vfauth opened a new pull request, #341: Respect rbac.limit_to_namespace for Functions RBAC
vfauth opened a new pull request, #341:
URL: https://github.com/apache/pulsar-helm-chart/pull/341
Fixes #<xyz>
### Motivation
The chart already has a `rbac.limit_to_namespace` parameter to replace ClusterRole(Binding)s with Role(Binding)s. This setting is not used for a ClusterRole required by the functions component, which is an issue for deployments in constrained with limited cluster. See #246
### Modifications
Handle ClusterRole(Binding) for the functions component the same way as for other components: if `rbac.limit_to_namespace` is `true`, use namespaced Role(Binding) instead.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] vfauth commented on pull request #341: Respect rbac.limit_to_namespace for Functions RBAC
Posted by "vfauth (via GitHub)" <gi...@apache.org>.
vfauth commented on PR #341:
URL: https://github.com/apache/pulsar-helm-chart/pull/341#issuecomment-1634612612
@lhotari They fix the same issue, so you can close mine, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Respect rbac.limit_to_namespace for Functions RBAC [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #341:
URL: https://github.com/apache/pulsar-helm-chart/pull/341#issuecomment-1849629127
Closing this one since #236 was already merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] vfauth commented on pull request #341: Respect rbac.limit_to_namespace for Functions RBAC
Posted by GitBox <gi...@apache.org>.
vfauth commented on PR #341:
URL: https://github.com/apache/pulsar-helm-chart/pull/341#issuecomment-1350738686
@michaeljmarshall It is already present in `values.yaml`: https://github.com/apache/pulsar-helm-chart/blob/master/charts/pulsar/values.yaml#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Respect rbac.limit_to_namespace for Functions RBAC [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #341: Respect rbac.limit_to_namespace for Functions RBAC
URL: https://github.com/apache/pulsar-helm-chart/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on pull request #341: Respect rbac.limit_to_namespace for Functions RBAC
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #341:
URL: https://github.com/apache/pulsar-helm-chart/pull/341#issuecomment-1632752029
@vfauth I happened to merge #236 which had similar changes. Would you mind checking if the result is desirable? If not, please create a new PR to revisit the solution. One detail is that it would be useful to make the changes backwards compatible so that the roles don't change for existing deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] vfauth commented on pull request #341: Respect rbac.limit_to_namespace for Functions RBAC
Posted by "vfauth (via GitHub)" <gi...@apache.org>.
vfauth commented on PR #341:
URL: https://github.com/apache/pulsar-helm-chart/pull/341#issuecomment-1476043035
Any news on merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org