You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/04/02 16:51:50 UTC

Review Request 45618: Log streaming disabled in Oozie

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45618/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.


Bugs: AMBARI-15676
    https://issues.apache.org/jira/browse/AMBARI-15676


Repository: ambari


Description
-------

When I execute the oozie log command in the latest builds it is showing as "Log streaming disabled" .


Diffs
-----

  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml b4518ce 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-log4j.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/45618/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 45618: Log streaming disabled in Oozie

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On Квітень 2, 2016, 9:45 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-log4j.xml, line 1
> > <https://reviews.apache.org/r/45618/diff/1/?file=1323252#file1323252line1>
> >
> >     Why is this file needed? Should HDP-2.2 not inherit from common services?

In common services we have Oozie 4.0. HDP-2.2 provides Oozie 4.1. log4j properties are a little bit different for these two versions.
Minimal supported HDP version is 2.2 so we can move that config to common services. But isn't it confusing to have Oozie 4.1 config in OOZIE/4.0.0.2.0 ?


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45618/#review126701
-----------------------------------------------------------


On Квітень 2, 2016, 2:51 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45618/
> -----------------------------------------------------------
> 
> (Updated Квітень 2, 2016, 2:51 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15676
>     https://issues.apache.org/jira/browse/AMBARI-15676
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When I execute the oozie log command in the latest builds it is showing as "Log streaming disabled" .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml b4518ce 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-log4j.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45618/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 45618: Log streaming disabled in Oozie

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45618/#review126701
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-log4j.xml (line 1)
<https://reviews.apache.org/r/45618/#comment189722>

    Why is this file needed? Should HDP-2.2 not inherit from common services?


- Sumit Mohanty


On April 2, 2016, 2:51 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45618/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15676
>     https://issues.apache.org/jira/browse/AMBARI-15676
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When I execute the oozie log command in the latest builds it is showing as "Log streaming disabled" .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml b4518ce 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/configuration/oozie-log4j.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45618/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 45618: Log streaming disabled in Oozie

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45618/#review126816
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Onischuk


On April 4, 2016, 11:56 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45618/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15676
>     https://issues.apache.org/jira/browse/AMBARI-15676
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When I execute the oozie log command in the latest builds it is showing as "Log streaming disabled" .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml b4518ce 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45618/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 45618: Log streaming disabled in Oozie

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45618/
-----------------------------------------------------------

(Updated Квітень 4, 2016, 11:56 до полудня)


Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.


Bugs: AMBARI-15676
    https://issues.apache.org/jira/browse/AMBARI-15676


Repository: ambari


Description
-------

When I execute the oozie log command in the latest builds it is showing as "Log streaming disabled" .


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml b4518ce 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/45618/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi