You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/10/08 00:04:38 UTC

[GitHub] [logging-log4cxx] swebb2066 commented on a diff in pull request #140: Prefer a file named like the executable for configuration data.

swebb2066 commented on code in PR #140:
URL: https://github.com/apache/logging-log4cxx/pull/140#discussion_r990557201


##########
src/main/cpp/defaultconfigurator.cpp:
##########
@@ -60,17 +131,32 @@ void DefaultConfigurator::configure(LoggerRepositoryPtr repository)
 
 	if (configurationFileName.empty())
 	{
-		const char* names[] = { "log4cxx.xml", "log4cxx.properties", "log4j.xml", "log4j.properties", 0 };

Review Comment:
   I will have to abandon this PR as I do not know how to make it work on Macos.
   
   I am thinking I will put the file name selection code in an example MyLogManager.cpp instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org