You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/23 06:34:01 UTC

[GitHub] [activemq] jbonofre commented on a change in pull request #352: Applied fix for data writer thread dying an early death

jbonofre commented on a change in pull request #352:
URL: https://github.com/apache/activemq/pull/352#discussion_r599302737



##########
File path: activemq-core/src/main/java/org/apache/activemq/kaha/impl/async/DataFileAppender.java
##########
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
+ * <p>

Review comment:
       This kind of change is useless in the PR: it actually creates confusion, as the change part is actually small (exception handling), whereas the formatting changes creates noise.
   Can you please rework the PR ? Else, I will extract the change part.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org