You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/08 16:39:22 UTC

[GitHub] [tvm] NicolaLancellotti commented on pull request #12029: [microNPU] Add MergeConstants pass

NicolaLancellotti commented on PR #12029:
URL: https://github.com/apache/tvm/pull/12029#issuecomment-1179179784

   > Thanks @NicolaLancellotti !
   > 
   > I have a done a round of reviews. There are few things we should improve in the PR. See if you agree.
   > 
   > Also please consider adding docs for non-trivial functions.
   > 
   > We need to align with coding style of TVM : https://tvm.apache.org/docs/contribute/code_guide.html (I have put a few specific comments to each type)
   
   Thanks for the review @manupa-arm!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org