You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/01 16:13:09 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9927: [fix] (planner) slot nullable is not set correctly when plan outer join with inline view
morrySnow opened a new pull request, #9927:
URL: https://github.com/apache/incubator-doris/pull/9927
# Proposed changes
Issue Number: close #9925
- do analyze join before generate sMap and baseTblSmap when analyze InlineViewRef
- propagate slot nullable when generate inline view's query node in SingleNodePlanner
## Problem Summary:
When plan left outer join, we need to set all SlotDescriptor at right hand to nullable. But under some case, it is not happen anymore.
Detail could be found in related issue #9925
## Checklist(Required)
1. Does it affect the original behavior: Yes
2. Has unit tests been added: No
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9927: [fix] (planner) slot nullable does not set correctly when plan outer join with inline view
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9927:
URL: https://github.com/apache/incubator-doris/pull/9927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9927: [fix] (planner) slot nullable does not set correctly when plan outer join with inline view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9927:
URL: https://github.com/apache/incubator-doris/pull/9927#issuecomment-1144576543
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9927: [fix] (planner) slot nullable is not set correctly when plan outer join with inline view
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9927:
URL: https://github.com/apache/incubator-doris/pull/9927#discussion_r886995035
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/InlineViewRef.java:
##########
@@ -207,7 +207,16 @@ public void analyze(Analyzer analyzer) throws AnalysisException, UserException {
materializedTupleIds.add(desc.getId());
}
- // create smap_ and baseTblSmap_ and register auxiliary eq predicates between our
+ // anlayzeLateralViewRefs
+ analyzeLateralViewRef(analyzer);
+
+ // We need to analyze join behind create sMap and baseTblSmap, because SlotDescriptors of inline view's
Review Comment:
```suggestion
// We need to analyze join before create sMap and baseTblSmap, because SlotDescriptors of inline view's
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9927: [fix] (planner) slot nullable does not set correctly when plan outer join with inline view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9927:
URL: https://github.com/apache/incubator-doris/pull/9927#issuecomment-1144576493
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org