You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2022/12/01 09:30:06 UTC

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 )

Change subject: IMPALA-11758: Fixed error detection for usage of reserved words.
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19290/7/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

http://gerrit.cloudera.org:8080/#/c/19290/7/fe/src/main/cup/sql-parser.cup@254
PS7, Line 254: (String)
Maybe using .toString() instead of the cast solve the problem with the failed tests.



-- 
To view, visit http://gerrit.cloudera.org:8080/19290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9605d80a25ff878d12f6ca2ebb99ac26298d8efa
Gerrit-Change-Number: 19290
Gerrit-PatchSet: 7
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 09:30:06 +0000
Gerrit-HasComments: Yes