You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2014/07/14 11:29:17 UTC

Review Request 23449: Fix for test_portable_ip.py script issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23449/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CS-6992
    https://issues.apache.org/jira/browse/CS-6992


Repository: cloudstack-git


Description
-------

1.Portable Ip range dictionary is missing from services class inside test.So added it inside services class.
2.Undefined variable is used in many places. Corrected it.
3.Made changes to getPortableIpRangeServices method in tools/marvin/marvin/lib/common.py to read values properly from the config


Diffs
-----

  test/integration/component/test_portable_ip.py b9c9059 
  tools/marvin/marvin/lib/common.py 29677d3 

Diff: https://reviews.apache.org/r/23449/diff/


Testing
-------

Yes


Thanks,

sanjeev n

Re: Review Request 23449: Fix for test_portable_ip.py script issues

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23449/#review47712
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On July 14, 2014, 9:29 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23449/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 9:29 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CS-6992
>     https://issues.apache.org/jira/browse/CS-6992
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1.Portable Ip range dictionary is missing from services class inside test.So added it inside services class.
> 2.Undefined variable is used in many places. Corrected it.
> 3.Made changes to getPortableIpRangeServices method in tools/marvin/marvin/lib/common.py to read values properly from the config
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_portable_ip.py b9c9059 
>   tools/marvin/marvin/lib/common.py 29677d3 
> 
> Diff: https://reviews.apache.org/r/23449/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>