You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shiro.apache.org by "Tommy Becker (Jira)" <ji...@apache.org> on 2020/03/11 16:58:01 UTC

[jira] [Updated] (SHIRO-747) FirstSuccessfulStrategy doesn't properly short circuit

     [ https://issues.apache.org/jira/browse/SHIRO-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tommy Becker updated SHIRO-747:
-------------------------------
    Affects Version/s: 1.5.1

> FirstSuccessfulStrategy doesn't properly short circuit
> ------------------------------------------------------
>
>                 Key: SHIRO-747
>                 URL: https://issues.apache.org/jira/browse/SHIRO-747
>             Project: Shiro
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Tommy Becker
>            Priority: Major
>
> SHIRO-669 supposedly added a method to skip subsequent authentications if one had already succeeded. But it doesn't work; it conditions throwing the ShortCircuitIterationException in beforeAttempt() in part on the PrincipalCollection being empty, which it will (properly) not be if an authentication has succeeded. I believe the check should be that the it is *not* empty. Was this tested??



--
This message was sent by Atlassian Jira
(v8.3.4#803005)