[GitHub] [flink] paul8263 commented on a diff in pull request #19772: [FLINK-27579][client] The param client.timeout can not be set by dyna…

[GitBox <gi...@apache.org>]

paul8263 commented on code in PR #19772:
URL: https://github.com/apache/flink/pull/19772#discussion_r884501609


##########
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java:
##########
@@ -110,10 +110,6 @@ public class CliFrontend {
 
     private final Options customCommandLineOptions;
 
-    private final Duration clientTimeout;
-
-    private final int defaultParallelism;
-

Review Comment:
   Hi @Myracle ,
   -p specifies parallelism and it is not the default parallelism.
   ```java
   int parallelism = programOptions.getParallelism();
   if (ExecutionConfig.PARALLELISM_DEFAULT == parallelism) {
       parallelism = getDefaultParallelism(effectiveConfiguration);
   }
   ```
   If parallelism is not specified (it will use the default value), then Flink will read the default value from the comfiguration file or dynamic properties.
   I think we need to move a variable from a class field to a local variable if it is not required to be accessed from multiple methods.
   Correct me if I am wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org