You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/10/01 10:09:20 UTC
[GitHub] ashb commented on issue #3981: [AIRFLOW-3133] disable default
return value for SSHOperator
ashb commented on issue #3981: [AIRFLOW-3133] disable default return value for SSHOperator
URL: https://github.com/apache/incubator-airflow/pull/3981#issuecomment-425855530
@itscaro Yup, this looks good. Other operators should probably not `return true` either. Do you want to update this PR to remove the other uses of `return true`?
As for the ones that return - we should probably put those behind an `xcom_push` flag with a default value of True (so that the usage of the operator doesn't change). Again, would you like to do that here? Or we can create an issue and someone else could pick that up if you don't have time/desire.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services