You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/17 11:40:53 UTC
[GitHub] [skywalking] codecov[bot] commented on pull request #4942: Multi-data source (same host:port) gets db.instance data error #4941
codecov[bot] commented on pull request #4942:
URL: https://github.com/apache/skywalking/pull/4942#issuecomment-645322689
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=h1) Report
> Merging [#4942](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/99ae1962478d41c25f7feebeee80fffa79fb5061&el=desc) will **increase** coverage by `5.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4942 +/- ##
============================================
+ Coverage 51.31% 56.89% +5.57%
+ Complexity 2747 673 -2074
============================================
Files 1353 145 -1208
Lines 29427 3563 -25864
Branches 3257 426 -2831
============================================
- Hits 15100 2027 -13073
+ Misses 13611 1277 -12334
+ Partials 716 259 -457
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../core/logging/core/coverts/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `18.18% <0.00%> (-63.64%)` | `2.00% <0.00%> (ø%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `13.20% <0.00%> (-53.46%)` | `4.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `26.66% <0.00%> (-50.00%)` | `7.00% <0.00%> (ø%)` | |
| [.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `28.57% <0.00%> (-42.86%)` | `5.00% <0.00%> (ø%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (-42.86%)` | `2.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `33.33% <0.00%> (-33.34%)` | `1.00% <0.00%> (ø%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `50.00% <0.00%> (-33.34%)` | `13.00% <0.00%> (ø%)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `66.66% <0.00%> (-33.34%)` | `3.00% <0.00%> (ø%)` | |
| ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/4942/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=footer). Last update [99ae196...3eca9fd](https://codecov.io/gh/apache/skywalking/pull/4942?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org