You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/05 08:07:32 UTC
[GitHub] [spark] cloud-fan opened a new pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
cloud-fan opened a new pull request #33213:
URL: https://github.com/apache/spark/pull/33213
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/33113, to do some code cleanup:
1. `UnresolvedFieldPosition` doesn't need to include the field name. We can get it through "context" (`AlterTableAlterColumn.column.name`).
2. Run `ResolveAlterTableCommands` in the main resolution batch, so that the column/field resolution is also unified between v1 and v2 commands (same error message).
3. Fail immediately in `ResolveAlterTableCommands` if we can't resolve the field, instead of waiting until `CheckAnalysis`. We don't expect other rules to resolve fields in ALTER TABLE commands, so failing immediately is simpler and we can remove duplicated code in `CheckAnalysis`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
code simplification.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873976390
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45154/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873899622
cc @imback82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874174385
**[Test build #140660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140660/testReport)** for PR 33213 at commit [`c31f8ba`](https://github.com/apache/spark/commit/c31f8ba6dd24ee9c2a2c781f8c1767b94c6ebab5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873933905
**[Test build #140645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140645/testReport)** for PR 33213 at commit [`5246630`](https://github.com/apache/spark/commit/52466300ce12e95732c639583d9d353a4350aba7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874218562
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873994853
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873902830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874208163
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874218562
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874338993
**[Test build #140668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140668/testReport)** for PR 33213 at commit [`52383ba`](https://github.com/apache/spark/commit/52383baf47bdea4097a9ebbcd8722d03ca1c2b9c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873932370
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140642/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873933905
**[Test build #140645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140645/testReport)** for PR 33213 at commit [`5246630`](https://github.com/apache/spark/commit/52466300ce12e95732c639583d9d353a4350aba7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33213:
URL: https://github.com/apache/spark/pull/33213#discussion_r663754582
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala
##########
@@ -372,7 +372,7 @@ case class StructType(fields: Array[StructField]) extends DataType with Seq[Stru
findField(struct, names, normalizedPath ++ Seq(field.name, "element"))
case _ =>
- None
+ throw QueryCompilationErrors.invalidFieldName(fieldNames, normalizedPath)
Review comment:
This is to match https://github.com/apache/spark/pull/33213/files#diff-583171e935b2dc349378063a5841c5b98b30a2d57ac3743a9eccfe7bffcb8f2aL472
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -321,7 +321,7 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
val msg = intercept[AnalysisException] {
sql(s"ALTER TABLE $tableName ALTER COLUMN bad_column COMMENT 'test'")
}.getMessage
- assert(msg.contains("Cannot update missing field bad_column in h2.test.alt_table"))
+ assert(msg.contains("Missing field bad_column in table h2.test.alt_table"))
Review comment:
sounds good, thanks!
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -450,43 +450,6 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
write.query.schema.foreach(f => TypeUtils.failWithIntervalType(f.dataType))
case alter: AlterTableCommand if alter.table.resolved =>
- val table = alter.table.asInstanceOf[ResolvedTable]
- def findField(fieldName: Seq[String]): StructField = {
- // Include collections because structs nested in maps and arrays may be altered.
- val field = table.schema.findNestedField(fieldName, includeCollections = true)
- if (field.isEmpty) {
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${fieldName.quoted} " +
- s"in ${table.name} schema: ${table.schema.treeString}")
- }
- field.get._2
- }
- def findParentStruct(fieldNames: Seq[String]): StructType = {
- val parent = fieldNames.init
- val field = if (parent.nonEmpty) {
- findField(parent).dataType
- } else {
- table.schema
- }
- field match {
- case s: StructType => s
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldNames.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- }
- alter.transformExpressions {
- case UnresolvedFieldName(name) =>
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${name.quoted} in " +
- s"${table.name} schema: ${table.schema.treeString}")
- case UnresolvedFieldPosition(fieldName, position: After) =>
- val parent = findParentStruct(fieldName)
- val allFields = parent match {
- case s: StructType => s.fieldNames
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldName.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- alter.failAnalysis(s"Couldn't resolve positional argument $position amongst " +
Review comment:
The error message can refer to a position in the SQL string, which should provide sufficient context. The missing top-level column also uses a simple error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874208163
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140660/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #33213:
URL: https://github.com/apache/spark/pull/33213#discussion_r664064796
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -321,7 +321,7 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
val msg = intercept[AnalysisException] {
sql(s"ALTER TABLE $tableName ALTER COLUMN bad_column COMMENT 'test'")
}.getMessage
- assert(msg.contains("Cannot update missing field bad_column in h2.test.alt_table"))
+ assert(msg.contains("Missing field bad_column in table h2.test.alt_table"))
Review comment:
If we are simplifying the message, we may not need to have `AlterTableComand.operation`. I can remove it in #33200.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -450,43 +450,6 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
write.query.schema.foreach(f => TypeUtils.failWithIntervalType(f.dataType))
case alter: AlterTableCommand if alter.table.resolved =>
- val table = alter.table.asInstanceOf[ResolvedTable]
- def findField(fieldName: Seq[String]): StructField = {
- // Include collections because structs nested in maps and arrays may be altered.
- val field = table.schema.findNestedField(fieldName, includeCollections = true)
- if (field.isEmpty) {
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${fieldName.quoted} " +
- s"in ${table.name} schema: ${table.schema.treeString}")
- }
- field.get._2
- }
- def findParentStruct(fieldNames: Seq[String]): StructType = {
- val parent = fieldNames.init
- val field = if (parent.nonEmpty) {
- findField(parent).dataType
- } else {
- table.schema
- }
- field match {
- case s: StructType => s
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldNames.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- }
- alter.transformExpressions {
- case UnresolvedFieldName(name) =>
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${name.quoted} in " +
- s"${table.name} schema: ${table.schema.treeString}")
- case UnresolvedFieldPosition(fieldName, position: After) =>
- val parent = findParentStruct(fieldName)
- val allFields = parent match {
- case s: StructType => s.fieldNames
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldName.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- alter.failAnalysis(s"Couldn't resolve positional argument $position amongst " +
Review comment:
`UnresolvedFieldPosition` was carrying `fieldName` to reconstruct this message (no need to match by commands). If this is not needed anymore, we can drop `fieldName`. Thanks for cleaning this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874019864
**[Test build #140645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140645/testReport)** for PR 33213 at commit [`5246630`](https://github.com/apache/spark/commit/52466300ce12e95732c639583d9d353a4350aba7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class UnresolvedFieldPosition(position: ColumnPosition) extends FieldPosition `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873902830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874174385
**[Test build #140660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140660/testReport)** for PR 33213 at commit [`c31f8ba`](https://github.com/apache/spark/commit/c31f8ba6dd24ee9c2a2c781f8c1767b94c6ebab5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33213:
URL: https://github.com/apache/spark/pull/33213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874020538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140645/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #33213:
URL: https://github.com/apache/spark/pull/33213#discussion_r664064796
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -321,7 +321,7 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
val msg = intercept[AnalysisException] {
sql(s"ALTER TABLE $tableName ALTER COLUMN bad_column COMMENT 'test'")
}.getMessage
- assert(msg.contains("Cannot update missing field bad_column in h2.test.alt_table"))
+ assert(msg.contains("Missing field bad_column in table h2.test.alt_table"))
Review comment:
If we are simplifying the message, we may not need to have `AlterTableComand.operation`. I can remove it in #33200.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -450,43 +450,6 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
write.query.schema.foreach(f => TypeUtils.failWithIntervalType(f.dataType))
case alter: AlterTableCommand if alter.table.resolved =>
- val table = alter.table.asInstanceOf[ResolvedTable]
- def findField(fieldName: Seq[String]): StructField = {
- // Include collections because structs nested in maps and arrays may be altered.
- val field = table.schema.findNestedField(fieldName, includeCollections = true)
- if (field.isEmpty) {
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${fieldName.quoted} " +
- s"in ${table.name} schema: ${table.schema.treeString}")
- }
- field.get._2
- }
- def findParentStruct(fieldNames: Seq[String]): StructType = {
- val parent = fieldNames.init
- val field = if (parent.nonEmpty) {
- findField(parent).dataType
- } else {
- table.schema
- }
- field match {
- case s: StructType => s
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldNames.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- }
- alter.transformExpressions {
- case UnresolvedFieldName(name) =>
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${name.quoted} in " +
- s"${table.name} schema: ${table.schema.treeString}")
- case UnresolvedFieldPosition(fieldName, position: After) =>
- val parent = findParentStruct(fieldName)
- val allFields = parent match {
- case s: StructType => s.fieldNames
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldName.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- alter.failAnalysis(s"Couldn't resolve positional argument $position amongst " +
Review comment:
`UnresolvedFieldPosition` was carrying `fieldName` to reconstruct this message (no need to match by commands). If this is not needed anymore, we can drop `fieldName`. Thanks for cleaning this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873967678
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45154/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874262873
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45179/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873976390
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45154/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874199305
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873906796
**[Test build #140642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140642/testReport)** for PR 33213 at commit [`34bd690`](https://github.com/apache/spark/commit/34bd69056a12cd2b34068d781ba1aff21107449b).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class UnresolvedFieldPosition(position: ColumnPosition) extends FieldPosition `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874241693
**[Test build #140668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140668/testReport)** for PR 33213 at commit [`52383ba`](https://github.com/apache/spark/commit/52383baf47bdea4097a9ebbcd8722d03ca1c2b9c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874281609
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45179/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874281609
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45179/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33213:
URL: https://github.com/apache/spark/pull/33213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33213:
URL: https://github.com/apache/spark/pull/33213#discussion_r663754582
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala
##########
@@ -372,7 +372,7 @@ case class StructType(fields: Array[StructField]) extends DataType with Seq[Stru
findField(struct, names, normalizedPath ++ Seq(field.name, "element"))
case _ =>
- None
+ throw QueryCompilationErrors.invalidFieldName(fieldNames, normalizedPath)
Review comment:
This is to match https://github.com/apache/spark/pull/33213/files#diff-583171e935b2dc349378063a5841c5b98b30a2d57ac3743a9eccfe7bffcb8f2aL472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874275887
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45179/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874016371
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33213:
URL: https://github.com/apache/spark/pull/33213#discussion_r664104111
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
##########
@@ -321,7 +321,7 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
val msg = intercept[AnalysisException] {
sql(s"ALTER TABLE $tableName ALTER COLUMN bad_column COMMENT 'test'")
}.getMessage
- assert(msg.contains("Cannot update missing field bad_column in h2.test.alt_table"))
+ assert(msg.contains("Missing field bad_column in table h2.test.alt_table"))
Review comment:
sounds good, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33213:
URL: https://github.com/apache/spark/pull/33213#discussion_r664104896
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -450,43 +450,6 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
write.query.schema.foreach(f => TypeUtils.failWithIntervalType(f.dataType))
case alter: AlterTableCommand if alter.table.resolved =>
- val table = alter.table.asInstanceOf[ResolvedTable]
- def findField(fieldName: Seq[String]): StructField = {
- // Include collections because structs nested in maps and arrays may be altered.
- val field = table.schema.findNestedField(fieldName, includeCollections = true)
- if (field.isEmpty) {
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${fieldName.quoted} " +
- s"in ${table.name} schema: ${table.schema.treeString}")
- }
- field.get._2
- }
- def findParentStruct(fieldNames: Seq[String]): StructType = {
- val parent = fieldNames.init
- val field = if (parent.nonEmpty) {
- findField(parent).dataType
- } else {
- table.schema
- }
- field match {
- case s: StructType => s
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldNames.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- }
- alter.transformExpressions {
- case UnresolvedFieldName(name) =>
- alter.failAnalysis(s"Cannot ${alter.operation} missing field ${name.quoted} in " +
- s"${table.name} schema: ${table.schema.treeString}")
- case UnresolvedFieldPosition(fieldName, position: After) =>
- val parent = findParentStruct(fieldName)
- val allFields = parent match {
- case s: StructType => s.fieldNames
- case o => alter.failAnalysis(s"Cannot ${alter.operation} ${fieldName.quoted}, " +
- s"because its parent is not a StructType. Found $o")
- }
- alter.failAnalysis(s"Couldn't resolve positional argument $position amongst " +
Review comment:
The error message can refer to a position in the SQL string, which should provide sufficient context. The missing top-level column also uses a simple error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873932370
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140642/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874016371
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873932370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874206890
**[Test build #140660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140660/testReport)** for PR 33213 at commit [`c31f8ba`](https://github.com/apache/spark/commit/c31f8ba6dd24ee9c2a2c781f8c1767b94c6ebab5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class UnresolvedFieldPosition(position: ColumnPosition) extends FieldPosition `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873899622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874344229
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140668/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874299624
thanks for the review, merging to master/3.2 (since it's a followup).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873902830
**[Test build #140642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140642/testReport)** for PR 33213 at commit [`34bd690`](https://github.com/apache/spark/commit/34bd69056a12cd2b34068d781ba1aff21107449b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873932370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874344229
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140668/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874218536
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45171/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874241693
**[Test build #140668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140668/testReport)** for PR 33213 at commit [`52383ba`](https://github.com/apache/spark/commit/52383baf47bdea4097a9ebbcd8722d03ca1c2b9c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873902830
**[Test build #140642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140642/testReport)** for PR 33213 at commit [`34bd690`](https://github.com/apache/spark/commit/34bd69056a12cd2b34068d781ba1aff21107449b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873970461
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-874020538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140645/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33213: [SPARK-34302][SQL][FOLLOWUP] More code cleanup
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33213:
URL: https://github.com/apache/spark/pull/33213#issuecomment-873941152
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45154/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org