[GitHub] chaoyli commented on a change in pull request #516: Modify compaction code to be adapted to Rowset interface

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #516: Modify compaction code to be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246615716
 
 

 ##########
 File path: be/src/olap/base_compaction.cpp
 ##########
 @@ -142,12 +139,20 @@ OLAPStatus BaseCompaction::run() {
         return res;
     }
 
+    //  validate that delete action is right
+    //  if error happened, sleep 1 hour. Report a fatal log every 1 minute
+    if (_validate_delete_file_action() != OLAP_SUCCESS) {
+        LOG(WARNING) << "failed to do base compaction. delete action has error.";
+        _garbage_collection();
+        return OLAP_ERR_BE_ERROR_DELETE_ACTION;
+    }
+
     VLOG(3) << "elapsed time of doing base compaction:" << stage_watch.get_elapse_time_us();
 
     // 4. make new versions visable.
     //    If success, remove files belong to old versions;
     //    If fail, gc files belong to new versions.
-    vector<SegmentGroup*> unused_olap_indices;
+    vector<RowsetSharedPtr> unused_olap_indices;
 
 Review comment:
   OK. I will change it to unused_rowsets.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org