You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/04 02:48:26 UTC

[GitHub] [incubator-superset] hughhhh opened a new pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

hughhhh opened a new pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Since the branch name was breaking dock
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#issuecomment-738582332


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=h1) Report
   > Merging [#11922](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=desc) (39d8dc9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11922/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11922      +/-   ##
   ==========================================
   + Coverage   67.68%   67.71%   +0.02%     
   ==========================================
     Files         930      930              
     Lines       45132    45134       +2     
     Branches     4331     4331              
   ==========================================
   + Hits        30549    30562      +13     
   + Misses      14480    14469      -11     
     Partials      103      103              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.23% <100.00%> (+0.34%)` | :arrow_up: |
   | javascript | `63.16% <75.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.23% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.52% <100.00%> (+0.23%)` | :arrow_up: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `64.95% <0.00%> (+0.42%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
   | [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `60.78% <0.00%> (+7.84%)` | :arrow_up: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=footer). Last update [e0288bf...39d8dc9](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#discussion_r536234459



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
       queriesArray: [],
       dataPreviewQueries: [],
       hideLeftBar: false,
+      databaseIds: getDatabasesIds(),

Review comment:
       I'm ok with this as a quick fix to unblock if we revisit quickly. But I don't think fetching in components is great, especially in constructors as it will hold things up.
   
   Pointing out two relevant redux actions that could be useful for the following PR:
   
   https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/SqlLab/actions/sqlLab.js#L436
   
   https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/SqlLab/actions/sqlLab.js#L744




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#issuecomment-738582332


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=h1) Report
   > Merging [#11922](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=desc) (39d8dc9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `0.03%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11922/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11922      +/-   ##
   ==========================================
   + Coverage   67.68%   67.71%   +0.03%     
   ==========================================
     Files         930      930              
     Lines       45132    45134       +2     
     Branches     4331     4331              
   ==========================================
   + Hits        30549    30564      +15     
   + Misses      14480    14467      -13     
     Partials      103      103              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.27% <100.00%> (+0.37%)` | :arrow_up: |
   | javascript | `63.16% <75.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.23% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.52% <100.00%> (+0.23%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `64.95% <0.00%> (+0.42%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
   | [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `60.78% <0.00%> (+7.84%)` | :arrow_up: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=footer). Last update [e0288bf...39d8dc9](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] hughhhh commented on a change in pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#discussion_r536189285



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
       queriesArray: [],
       dataPreviewQueries: [],
       hideLeftBar: false,
+      databaseIds: getDatabasesIds(),

Review comment:
       @mistercrunch 
   
   Currently the database selector is using `<SupersetAsyncSelect/>` which doesn't allow the TabbedSqlEditors to have a reference for the databases available. So i'm basically following the same pattern but in our component using `makeApi`.
   
   This is blocking for this weeks release so I wanted to fix the issue, and then I can look into moving this code into redux.
   
   https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/components/DatabaseSelector.tsx#L222




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#issuecomment-738582332


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=h1) Report
   > Merging [#11922](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=desc) (39d8dc9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11922/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11922      +/-   ##
   ==========================================
   + Coverage   67.68%   67.71%   +0.02%     
   ==========================================
     Files         930      930              
     Lines       45132    45134       +2     
     Branches     4331     4331              
   ==========================================
   + Hits        30549    30562      +13     
   + Misses      14480    14469      -11     
     Partials      103      103              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.23% <100.00%> (+0.34%)` | :arrow_up: |
   | javascript | `63.16% <75.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.23% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.52% <100.00%> (+0.23%)` | :arrow_up: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `64.95% <0.00%> (+0.42%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
   | [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `60.78% <0.00%> (+7.84%)` | :arrow_up: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=footer). Last update [e0288bf...39d8dc9](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] hughhhh closed pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
hughhhh closed pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] hughhhh commented on a change in pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
hughhhh commented on a change in pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#discussion_r536189285



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
       queriesArray: [],
       dataPreviewQueries: [],
       hideLeftBar: false,
+      databaseIds: getDatabasesIds(),

Review comment:
       Currently the database selector is using `<SupersetAsyncSelect/>` which doesn't allow the TabbedSqlEditors to have a reference for the databases available. So i'm basically following the same pattern but in our component `makeApi`.
   
   This is blocking for this weeks release so I wanted to fix the issue, and then I can look into moving this code into redux.
   
   https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/components/DatabaseSelector.tsx#L222

##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
       queriesArray: [],
       dataPreviewQueries: [],
       hideLeftBar: false,
+      databaseIds: getDatabasesIds(),

Review comment:
       @mistercrunch 
   
   Currently the database selector is using `<SupersetAsyncSelect/>` which doesn't allow the TabbedSqlEditors to have a reference for the databases available. So i'm basically following the same pattern but in our component `makeApi`.
   
   This is blocking for this weeks release so I wanted to fix the issue, and then I can look into moving this code into redux.
   
   https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/components/DatabaseSelector.tsx#L222




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#discussion_r535848059



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -76,6 +85,7 @@ class TabbedSqlEditors extends React.PureComponent {
       queriesArray: [],
       dataPreviewQueries: [],
       hideLeftBar: false,
+      databaseIds: getDatabasesIds(),

Review comment:
       Mmmh, we're already pulling the database list to populate the dropdown, can we just use/share that? Wondering why it used to work and doesn't anymore (?)
   
   It seems to me like this belongs somewhere in redux land.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#issuecomment-738582332


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=h1) Report
   > Merging [#11922](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=desc) (39d8dc9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11922/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11922      +/-   ##
   ==========================================
   + Coverage   67.68%   67.71%   +0.02%     
   ==========================================
     Files         930      930              
     Lines       45132    45134       +2     
     Branches     4331     4331              
   ==========================================
   + Hits        30549    30562      +13     
   + Misses      14480    14469      -11     
     Partials      103      103              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.23% <100.00%> (+0.34%)` | :arrow_up: |
   | javascript | `63.16% <75.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.23% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.52% <100.00%> (+0.23%)` | :arrow_up: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `64.95% <0.00%> (+0.42%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
   | [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `60.78% <0.00%> (+7.84%)` | :arrow_up: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=footer). Last update [e0288bf...39d8dc9](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#issuecomment-738582332


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=h1) Report
   > Merging [#11922](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=desc) (39d8dc9) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11922/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11922      +/-   ##
   ==========================================
   + Coverage   67.68%   67.71%   +0.02%     
   ==========================================
     Files         930      930              
     Lines       45132    45134       +2     
     Branches     4331     4331              
   ==========================================
   + Hits        30549    30562      +13     
   + Misses      14480    14469      -11     
     Partials      103      103              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.23% <100.00%> (+0.34%)` | :arrow_up: |
   | javascript | `63.16% <75.00%> (+<0.01%)` | :arrow_up: |
   | python | `64.23% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.52% <100.00%> (+0.23%)` | :arrow_up: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `64.95% <0.00%> (+0.42%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `81.01% <0.00%> (+1.26%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
   | [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `60.78% <0.00%> (+7.84%)` | :arrow_up: |
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11922/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=footer). Last update [e0288bf...39d8dc9](https://codecov.io/gh/apache/incubator-superset/pull/11922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #11922: fix: Pull databaseIds for TabbedSqlEditor Component II

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11922:
URL: https://github.com/apache/incubator-superset/pull/11922#issuecomment-738934253


   Alternative/root fix: https://github.com/apache/incubator-superset/pull/11934


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org