You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/01 03:33:44 UTC
[GitHub] [pulsar] ericsyh opened a new pull request, #16315: [fix](doc): incorrect tls config in java client doc
ericsyh opened a new pull request, #16315:
URL: https://github.com/apache/pulsar/pull/16315
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
On the [java client loadconf](https://pulsar.apache.org/docs/next/client-libraries-java/#client) page there is a config `useTls` on the list but I think this config should be the `enableTls` and I also check on [ClientBuilder](https://pulsar.apache.org/api/client/org/apache/pulsar/client/api/ClientBuilder.html) there is no method as `useTls`
### Modifications
Replace the incorrect tls config `useTls` by `enableTls` on the java client doc.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16315:
URL: https://github.com/apache/pulsar/pull/16315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r928653485
##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
`numIoThreads`| int| The number of threads used for handling connections to brokers | 1
`numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1
`useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false
Review Comment:
```suggestion
`enableTls` |boolean | Whether to use TLS encryption on the connection. Note that this parameter is **deprecated**. If you want to enable TLS, use `pulsar+ssl://` in `serviceUrl` instead. | false
```
do you mean this？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r924477597
##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
`numIoThreads`| int| The number of threads used for handling connections to brokers | 1
`numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1
`useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false
Review Comment:
what does `Deprecated` mean? `enableTls` is deprecated or something else？
##########
site2/website/versioned_docs/version-2.1.0-incubating/client-libraries-java.md:
##########
@@ -475,7 +475,7 @@ Pulsar currently supports two authentication schemes: [TLS](security-tls-authent
### TLS Authentication
-To use [TLS](security-tls-authentication), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
@momo-jun FYI: here is a missing occurrence (the `.md` issue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
ericsyh commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r928598894
##########
site2/docs/client-libraries-java.md:
##########
@@ -1513,7 +1513,7 @@ Pulsar currently supports three authentication schemes: [TLS](security-tls-authe
### TLS Authentication
-To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
update in https://github.com/apache/pulsar/pull/16315/commits/f7d21fb776dcb90bd1a9ce4300f9385f090de094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r924535873
##########
site2/website/versioned_docs/version-2.1.0-incubating/client-libraries-java.md:
##########
@@ -475,7 +475,7 @@ Pulsar currently supports two authentication schemes: [TLS](security-tls-authent
### TLS Authentication
-To use [TLS](security-tls-authentication), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
Thanks for the reminder. I didn't have a chance to fix them in doc versions earlier than 2.10. There are hundreds of them in each version, so I need to implement it separately to avoid getting dizzy and crazy. Maybe I can file an good-first-issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
dave2wave commented on PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#issuecomment-1177961625
I think that this looks correct, but there are conflicts to resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r929446924
##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
`numIoThreads`| int| The number of threads used for handling connections to brokers | 1
`numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1
`useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false
Review Comment:
can you update it? @ericsyh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r924535873
##########
site2/website/versioned_docs/version-2.1.0-incubating/client-libraries-java.md:
##########
@@ -475,7 +475,7 @@ Pulsar currently supports two authentication schemes: [TLS](security-tls-authent
### TLS Authentication
-To use [TLS](security-tls-authentication), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
Thanks for the reminder. I just covered three versions 2.10.0, 2.10.1, and master, but didn't have a chance to fix them in doc versions earlier than 2.10. There are hundreds of them in each version, so I need to implement it by phase to avoid getting dizzy and crazy. Maybe I can file an good-first-issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
ericsyh commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r926377557
##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
`numIoThreads`| int| The number of threads used for handling connections to brokers | 1
`numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1
`useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false
Review Comment:
There is no need to config `enableTls` in pulsar client to enable Tls, just use `pulsar+ssl://` in the connection address
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
ericsyh commented on PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#issuecomment-1186132942
> I think that this looks correct, but there are conflicts to resolve
@michaeljmarshall @dave2wave Conflicts resolved. PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r928684387
##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
`numIoThreads`| int| The number of threads used for handling connections to brokers | 1
`numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1
`useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false
Review Comment:
You are right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#issuecomment-1200578064
@tisonkun thanks!
@ericsyh I've merged your PR with modifying the commit message to `[fix][doc] fix incorrect tls config in java client doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
ericsyh commented on PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#issuecomment-1188790584
cc @Anonymitaet Could help take a look at this Doc PR or assign a technical review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
ericsyh commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r927428338
##########
site2/docs/client-libraries-java.md:
##########
@@ -1513,7 +1513,7 @@ Pulsar currently supports three authentication schemes: [TLS](security-tls-authe
### TLS Authentication
-To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
@nodece updated in https://github.com/apache/pulsar/pull/16315/commits/5d5d10252ec65fa0217d78747f62997d006dd3a3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
ericsyh commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r929668367
##########
site2/docs/client-libraries-java.md:
##########
@@ -140,7 +140,7 @@ If you create a client, you can use the `loadConf` configuration. The following
`numIoThreads`| int| The number of threads used for handling connections to brokers | 1
`numListenerThreads`|int|The number of threads used for handling message listeners. The listener thread pool is shared across all the consumers and readers using the "listener" model to get messages. For a given consumer, the listener is always invoked from the same thread to ensure ordering. If you want multiple threads to process a single topic, you need to create a [`shared`](/concepts-messaging.md#shared) subscription and multiple consumers for this subscription. This does not ensure ordering.| 1
`useTcpNoDelay`| boolean| Whether to use TCP no-delay flag on the connection to disable Nagle algorithm |true
-`useTls` |boolean |Whether to use TLS encryption on the connection| false
+`enableTls` |boolean | Whether to use TLS encryption on the connection. **Deprecated**. use "pulsar+ssl://" in serviceUrl to enable | false
Review Comment:
@Anonymitaet Updated in https://github.com/apache/pulsar/pull/16315/commits/9e233c5933a6c2caba4061270b62c40cc3632d76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r924655915
##########
site2/docs/client-libraries-java.md:
##########
@@ -1513,7 +1513,7 @@ Pulsar currently supports three authentication schemes: [TLS](security-tls-authe
### TLS Authentication
-To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
`enableTls` has been deprecated, I think we should explain `pulsar+ssl://` instead of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r927468321
##########
site2/docs/client-libraries-java.md:
##########
@@ -1513,7 +1513,7 @@ Pulsar currently supports three authentication schemes: [TLS](security-tls-authe
### TLS Authentication
-To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
Also you need to clean the `.enableTls(true)` in this documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16315: [fix](doc): incorrect tls config in java client doc
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16315:
URL: https://github.com/apache/pulsar/pull/16315#discussion_r928683891
##########
site2/docs/client-libraries-java.md:
##########
@@ -1513,7 +1513,7 @@ Pulsar currently supports three authentication schemes: [TLS](security-tls-authe
### TLS Authentication
-To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `setUseTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
+To use [TLS](security-tls-authentication.md), you need to set TLS to `true` using the `enableTls` method, point your Pulsar client to a TLS cert path, and provide paths to cert and key files.
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org