You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/12/16 07:10:58 UTC
[GitHub] [commons-dbcp] rzo1 opened a new pull request, #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
rzo1 opened a new pull request, #248:
URL: https://github.com/apache/commons-dbcp/pull/248
# What does this PR do?
This PR provides a Jakarta namespace ready artifact of DBCP2 by relocating the related `javax.transcation.*` imports to `jakarta.transaction.*` and provides a related (attached) artifact with a jakarta classifier to be consumed by user projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] rzo1 commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1356473724
Closing, see https://lists.apache.org/thread/kzoox2hkb484gyj1z13rn42xko2bp29w for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] rzo1 commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354373025
If we change the source code (which is indeed an option), it might be required to maintain two versions of dbcp2 as the javax namespace while be around for a long time. In the end, it would be great to have a Jakarta-ready version of DBCP2 available - otherwise, people are forced to do some "hacky" things to achive that.
I cannot follow regarding "binary compatibility" - maybe you can explain that point a bit more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] rzo1 commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354420435
@garydgregory So let's start a discussion on dev@ how the Commons wants to deal with Jakarta?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] rzo1 closed pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
rzo1 closed pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
URL: https://github.com/apache/commons-dbcp/pull/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354364907
While clever, this feels like a hack, untested as well. We should update the sources when we want to do this. We can't even tell if such a change would break binary compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] rmannibucau commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354381686
+1 to get it in or switch now (I know it is a bit early and it is not justified to get 2 "main" branches).
Note that if it helps adding a test is very feasible - we do at openwebbeans for ex - and enforcing binary compatiblity can be done too even if quite useless for this particular project (guess a test is a very good compromise since it will validate both at once).
The only change I would do is to relocate `org.apache.commons.dbcp2` in `org.apache.commons.dbcp2.jakarta` to ensure both can run together - yes it happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] codecov-commenter commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354314617
# [Codecov](https://codecov.io/gh/apache/commons-dbcp/pull/248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#248](https://codecov.io/gh/apache/commons-dbcp/pull/248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae20eda) into [master](https://codecov.io/gh/apache/commons-dbcp/commit/2008276a484d101d789f01bba68b444103a0eb4f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2008276) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #248 +/- ##
============================================
- Coverage 59.72% 59.71% -0.02%
Complexity 1783 1783
============================================
Files 57 57
Lines 7417 7417
Branches 421 421
============================================
- Hits 4430 4429 -1
- Misses 2770 2771 +1
Partials 217 217
```
| [Impacted Files](https://codecov.io/gh/apache/commons-dbcp/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/commons/dbcp2/managed/TransactionContext.java](https://codecov.io/gh/apache/commons-dbcp/pull/248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvZGJjcDIvbWFuYWdlZC9UcmFuc2FjdGlvbkNvbnRleHQuamF2YQ==) | `72.22% <0.00%> (-1.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] rmannibucau commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354435743
> impossible to debug, and again, untested
So factually you can debug as any artifact - you shade the sources too, it is used and got proven working fine by multiple asf projects.
And test is just a matter of writing some test or re-executing the suite ones if you prefer (but technically/theorically speaking you need just a smoke test covering the javax integration code to ensure it works since functionally the rest is already covered).
So overall both points are not blockers and are even almost not true.
> the sanest way to do that is changing the source
So it means jakarta is used on master, by commons rules it becomes dbcp3.
So, as mentionned question is: do we abandon dbcp2 and consider javax is no more used. If so I join you but if not (and I think we still have 2-3 years of javax) then we should target to enable jakarta (dbcp2.jakarta package) and maintain a single code base - would be a pain for no gain at all to fork ourselves for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #248: DBCP-589 - Provide Jakarta namespace ready artifact of DBCP2
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354415101
Please, no, -1; impossible to debug, and again, untested, also we ideally should have a consistent way to deal with Jakarta naming throughout Apache Commons, and the sanest way to do that is changing the source, if that breaks binary compatibility, then it can be done in a major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org