You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/07/05 10:51:03 UTC

[GitHub] [flink] zentol commented on a diff in pull request #22865: [FLINK-32421][test] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

zentol commented on code in PR #22865:
URL: https://github.com/apache/flink/pull/22865#discussion_r1252926401


##########
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedLeaderServiceTest.java:
##########
@@ -57,17 +49,18 @@ public void testConcurrentGrantLeadershipAndShutdown() throws Exception {
             leaderElection.startLeaderElection(contender);
             leaderElection.close();

Review Comment:
   If start() fails there's nothing to close.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org