You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/17 16:37:04 UTC

[GitHub] [apisix] gxthrj commented on a change in pull request #2776: feat(proxy-cache): the cache_zone field in the schema should be optional

gxthrj commented on a change in pull request #2776:
URL: https://github.com/apache/apisix/pull/2776#discussion_r525307352



##########
File path: doc/plugins/proxy-cache.md
##########
@@ -31,7 +31,7 @@ The proxy-cache plugin, which provides the ability to cache upstream response da
 
 | Name               | Type           | Requirement | Default                   | Valid                                                                           | Description                                                                                                                                                                                                                                  |
 | ------------------ | -------------- | ----------- | ------------------------- | ------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| cache_zone         | string         | required    |                           |                                                                                 | Specify which cache area to use, each cache area can be configured with different paths. In addition, cache areas can be predefined in conf/config.yaml file                                                                                 |
+| cache_zone         | string         | optional    |  disk_cache_one           |                                                                                 | Specify which cache area to use, each cache area can be configured with different paths. In addition, cache areas can be predefined in conf/config.yaml file                                                                                 |

Review comment:
       We need to tell people the cache will be invalid if `cache_zone` do not match.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org