You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jason Brown (JIRA)" <ji...@apache.org> on 2018/07/24 12:10:00 UTC
[jira] [Commented] (CASSANDRA-14545) dtests: fix pytest.raises
argument names
[ https://issues.apache.org/jira/browse/CASSANDRA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554170#comment-16554170 ]
Jason Brown commented on CASSANDRA-14545:
-----------------------------------------
[~mkjellman] isn't around these days, so I've taken a look. Double checked {{master}} for other {{msg}}/{{matches}} and this patch got them all. I also checked the pytest source to make sure {{match}}/{{message}} are the correct param names (they are).
+1
> dtests: fix pytest.raises argument names
> ----------------------------------------
>
> Key: CASSANDRA-14545
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14545
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
> Reporter: Stefan Podkowinski
> Assignee: Stefan Podkowinski
> Priority: Major
> Attachments: CASSANDRA-14545.patch
>
>
> I've been through a couple of [dtest results|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/580/#showFailuresLink] lately and notices some interpreter errors regarding how we call pytest.raises. The [reference|https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions] is pretty clear on what would be the correct arguments, but still want to make sure we're not working on different pytest versions.
> [~mkjellman] can you quickly check the following inconsistencies and look at my patch (msg->message, matches->match)?
> {noformat}
> git show 49b2dda4 |egrep 'raises.*, m' {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org