You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kayx23 (via GitHub)" <gi...@apache.org> on 2023/04/06 11:10:17 UTC

[GitHub] [apisix] kayx23 opened a new issue, #9255: enhancement: update the default rate limiting rejection code from 503 to 429

kayx23 opened a new issue, #9255:
URL: https://github.com/apache/apisix/issues/9255

   ### Current Behavior
   
   Previous discussion can be found here: https://www.mail-archive.com/dev@apisix.apache.org/msg05298.html
   
   Notably the following: 
   > The rate-limit plugin currently defaults to 503 HTTP response code for requests exceeding the configured rate limit. HTTP `429 Too Many Requests` seems to be a better fit: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/429 
   > 
   > 503 was initially used because Nginx's limit_req_status also uses 503 as the default. However, Nginx made its decision long before 429 became popular.
   
   This isn't a bug per se, but an enhancement, which has been noted should be announced as a breaking change. 
   
   Plugins in question:
   * limit-conn
   * limit-count
   * limit-req
   
   ### Expected Behavior
   
   _No response_
   
   ### Error Logs
   
   _No response_
   
   ### Steps to Reproduce
   
   https://docs.api7.ai/apisix/getting-started/rate-limiting
   
   ### Environment
   
   APISIX version 3.2
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] change: update the default rate limiting rejection code from 503 to 429 [apisix]

Posted by "nfrankel (via GitHub)" <gi...@apache.org>.
nfrankel commented on issue #9255:
URL: https://github.com/apache/apisix/issues/9255#issuecomment-1890862047

   I think you misunderstand my point.
   
   I'm not saying that it's not possible, I'm saying that the default is wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nfrankel commented on issue #9255: enhancement: update the default rate limiting rejection code from 503 to 429

Posted by "nfrankel (via GitHub)" <gi...@apache.org>.
nfrankel commented on issue #9255:
URL: https://github.com/apache/apisix/issues/9255#issuecomment-1498907092

   I stand by my initial point of view: we should strive to uphold the [principle of least astonishment](https://en.wikipedia.org/wiki/Principle_of_least_astonishment), which means return the expected code: 429 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] change: update the default rate limiting rejection code from 503 to 429 [apisix]

Posted by "smileby (via GitHub)" <gi...@apache.org>.
smileby commented on issue #9255:
URL: https://github.com/apache/apisix/issues/9255#issuecomment-1890836768

   > I stand by my initial point of view: we should strive to uphold the [principle of least astonishment](https://en.wikipedia.org/wiki/Principle_of_least_astonishment), which means return the expected code: 429
   > 
   > However, because it's a breaking change, we should defer the implementation until Apache APISIX 4.0
   
   I don’t think so. The ‘rejected_code’ response code itself supports user customization.  
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] kayx23 commented on issue #9255: enhancement: update the default rate limiting rejection code from 503 to 429

Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on issue #9255:
URL: https://github.com/apache/apisix/issues/9255#issuecomment-1498897150

   cc @nfrankel @moonming 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] change: update the default rate limiting rejection code from 503 to 429 [apisix]

Posted by "smileby (via GitHub)" <gi...@apache.org>.
smileby commented on issue #9255:
URL: https://github.com/apache/apisix/issues/9255#issuecomment-1890871687

   I ithink you are right


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org