You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Martijn Visser <ma...@apache.org> on 2022/10/07 14:10:22 UTC
Re: [VOTE] FLIP-254 Redis Streams connector
+1 (binding)
On Mon, Sep 19, 2022 at 3:49 AM Jingsong Li <ji...@gmail.com> wrote:
> +1 (binding)
>
> Best,
> Jingsong
>
> On Mon, Sep 19, 2022 at 2:20 PM Yu Li <ca...@gmail.com> wrote:
> >
> > +1 (binding)
> >
> > Thanks for the clarification Martijn. I'd suggest considering adding a
> note
> > in the FLIP document (since the proposed repository name for this
> connector
> > is "flink-connector-redis") or changing the repository name to
> > "flink-connector-redis-streams".
> >
> > Best Regards,
> > Yu
> >
> >
> > On Thu, 15 Sept 2022 at 20:45, Martijn Visser <ma...@apache.org>
> > wrote:
> >
> > > Hi Ryan and Yu,
> > >
> > > > There's quite a bit of existing code and it looks like there's
> > > > interest and community willing to contribute to this connector with 2
> > > > implementations already in the flink-connector-redis repo[1].
> > >
> > > Yes, this FLIP is to formalize that the Flink community wants to add
> this
> > > connector from that repository. We shouldn't have created the repo
> without
> > > having an accepted FLIP first :)
> > >
> > > > There's a couple of points that should probably be fixed in the FLIP
> > >
> > > Very good catch, I've updated the ones that you've mentioned.
> > >
> > > > does this FLIP only aim to add source/sink connectors for
> > > > Redis Streams, and we will create another one to support
> > > > regular Redis data structures (as LookupTableSource or Sink)?
> > >
> > > The scope of this FLIP is limited to adding a source/sink connector for
> > > Redis Streams. Things like LookupTableSource can be considered in the
> > > future.
> > >
> > > Best regards,
> > >
> > > Martijn
> > >
> > > Op di 13 sep. 2022 om 07:02 schreef Yu Li <ca...@gmail.com>:
> > >
> > > > Hi Martijn,
> > > >
> > > > Thanks for driving this forward, but from the discussion thread [1],
> it
> > > > seems one question from Konstantin is still not answered: does this
> FLIP
> > > > only aim to add source/sink connectors for Redis Streams, and we will
> > > > create another one to support regular Redis data structures (as
> > > > LookupTableSource or Sink)? I think it's necessary to confirm the
> scope
> > > of
> > > > the FLIP before voting (smile).
> > > >
> > > > Best Regards,
> > > > Yu
> > > >
> > > > [1] https://lists.apache.org/thread/9pftp3x10602nzr9c0ln4h9zt8hg2rjk
> > > >
> > > >
> > > > On Mon, 12 Sept 2022 at 22:05, Ryan Skraba
> <ryan.skraba@aiven.io.invalid
> > > >
> > > > wrote:
> > > >
> > > > > Hello! There's quite a bit of existing code and it looks like
> there's
> > > > > interest and community willing to contribute to this connector
> with 2
> > > > > implementations already in the flink-connector-redis repo[1].
> > > > >
> > > > > There's a couple of points that should probably be fixed in the
> FLIP:
> > > > some
> > > > > typos such as "provide at-least guarantees" and the initial version
> > > > should
> > > > > not be 1.0.0 given that version 1.1.5 was already released in its
> > > > previous
> > > > > incarnation[2].
> > > > >
> > > > > In principle: +1 (non-binding)
> > > > >
> > > > > All my best, Ryan
> > > > >
> > > > > [1]: https://github.com/apache/flink-connector-redis/pulls
> > > > > [2]:
> > > > >
> > > >
> > >
> https://mvnrepository.com/artifact/org.apache.flink/flink-connector-redis
> > > > >
> > > > >
> > > > >
> > > > > On Mon, Sep 12, 2022 at 10:20 AM Zheng Yu Chen <
> jam.gzczy@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > Martijn Visser <ma...@apache.org> 于2022年9月12日周一 15:58写道：
> > > > > >
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > With no comments provided in the discussion thread, I'm
> opening a
> > > > vote
> > > > > > > thread on FLIP-254: Redis Streams connector:
> > > > > > >
> > > > > > > FLIP:
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-254%3A+Redis+Streams+Connector
> > > > > > >
> > > > > > >
> > > > > > > The vote will be open for at least 72h.
> > > > > > >
> > > > > > > Best regards,
> > > > > > >
> > > > > > > Martijn
> > > > > > > https://twitter.com/MartijnVisser82
> > > > > > > https://github.com/MartijnVisser
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
>