[GitHub] nifi pull request: NIFI-1814 Extended caught exceptions

[JPercivall <gi...@git.apache.org>]

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/382#discussion_r62336974
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java ---
    @@ -155,9 +155,9 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
             try {
                 session.exportTo(flowFile, response.getOutputStream());
                 response.flushBuffer();
    -        } catch (final IOException ioe) {
    +        } catch (final Exception e) {
    --- End diff --
    
    Instead of changing this to blanket catching "Exception". Could another catch block that handles "FlowFileAccessException" be added, or just add it as another exception type caught in this block? 
    
    Blanket catching Exception is considered bad form so unless there is a specific need for it, I tend to stay away from it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---